Commit 714710e1 authored by Dmitry Torokhov's avatar Dmitry Torokhov Committed by Jason Cooper

irqchip: bcm7120-l2: Fix error handling of irq_of_parse_and_map

Return value of irq_of_parse_and_map() is unsigned int, with 0
indicating failure, so testing for negative result never works.
Signed-off-by: default avatarDmitry Torokhov <dtor@chromium.org>
Acked-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Tested-by: default avatarKevin Cernekee <cernekee@gmail.com>
Link: https://lkml.kernel.org/r/20141114221614.GA37395@dtor-wsSigned-off-by: default avatarJason Cooper <jason@lakedaemon.net>
parent 45977fe3
......@@ -101,9 +101,9 @@ static int bcm7120_l2_intc_init_one(struct device_node *dn,
int parent_irq;
parent_irq = irq_of_parse_and_map(dn, irq);
if (parent_irq < 0) {
if (!parent_irq) {
pr_err("failed to map interrupt %d\n", irq);
return parent_irq;
return -EINVAL;
}
data->irq_map_mask |= be32_to_cpup(map_mask + irq);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment