Commit 725a521a authored by Xiongfeng Wang's avatar Xiongfeng Wang Committed by Alex Deucher

drm/radeon: Fix PCI device refcount leak in radeon_atrm_get_bios()

As comment of pci_get_class() says, it returns a pci_device with its
refcount increased and decreased the refcount for the input parameter
@from if it is not NULL.

If we break the loop in radeon_atrm_get_bios() with 'pdev' not NULL, we
need to call pci_dev_put() to decrease the refcount. Add the missing
pci_dev_put() to avoid refcount leak.

Fixes: d8ade352 ("drm/radeon: handle non-VGA class pci devices with ATRM")
Fixes: c61e2775 ("drm/radeon: split ATRM support out from the ATPX handler (v3)")
Signed-off-by: default avatarXiongfeng Wang <wangxiongfeng2@huawei.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 7d4f8db4
...@@ -227,6 +227,7 @@ static bool radeon_atrm_get_bios(struct radeon_device *rdev) ...@@ -227,6 +227,7 @@ static bool radeon_atrm_get_bios(struct radeon_device *rdev)
if (!found) if (!found)
return false; return false;
pci_dev_put(pdev);
rdev->bios = kmalloc(size, GFP_KERNEL); rdev->bios = kmalloc(size, GFP_KERNEL);
if (!rdev->bios) { if (!rdev->bios) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment