Commit 7380f79c authored by Tudor Ambarus's avatar Tudor Ambarus

mtd: spi-nor: Don't overwrite errno from Reg Ops

Do not overwrite the error numbers received the Register Operations
methods.
Signed-off-by: default avatarTudor Ambarus <tudor.ambarus@microchip.com>
Reviewed-by: default avatarBoris Brezillon <boris.brezillon@collabora.com>
parent 17ccd0e4
...@@ -1364,10 +1364,9 @@ static int spi_nor_erase(struct mtd_info *mtd, struct erase_info *instr) ...@@ -1364,10 +1364,9 @@ static int spi_nor_erase(struct mtd_info *mtd, struct erase_info *instr)
spi_nor_write_enable(nor); spi_nor_write_enable(nor);
if (spi_nor_erase_chip(nor)) { ret = spi_nor_erase_chip(nor);
ret = -EIO; if (ret)
goto erase_err; goto erase_err;
}
/* /*
* Scale the timeout linearly with the size of the flash, with * Scale the timeout linearly with the size of the flash, with
...@@ -1839,7 +1838,7 @@ static int spansion_no_read_cr_quad_enable(struct spi_nor *nor) ...@@ -1839,7 +1838,7 @@ static int spansion_no_read_cr_quad_enable(struct spi_nor *nor)
ret = spi_nor_read_sr(nor); ret = spi_nor_read_sr(nor);
if (ret < 0) { if (ret < 0) {
dev_err(nor->dev, "error while reading status register\n"); dev_err(nor->dev, "error while reading status register\n");
return -EINVAL; return ret;
} }
sr_cr[0] = ret; sr_cr[0] = ret;
sr_cr[1] = CR_QUAD_EN_SPAN; sr_cr[1] = CR_QUAD_EN_SPAN;
...@@ -1870,7 +1869,7 @@ static int spansion_read_cr_quad_enable(struct spi_nor *nor) ...@@ -1870,7 +1869,7 @@ static int spansion_read_cr_quad_enable(struct spi_nor *nor)
ret = spi_nor_read_cr(nor); ret = spi_nor_read_cr(nor);
if (ret < 0) { if (ret < 0) {
dev_err(dev, "error while reading configuration register\n"); dev_err(dev, "error while reading configuration register\n");
return -EINVAL; return ret;
} }
if (ret & CR_QUAD_EN_SPAN) if (ret & CR_QUAD_EN_SPAN)
...@@ -1882,7 +1881,7 @@ static int spansion_read_cr_quad_enable(struct spi_nor *nor) ...@@ -1882,7 +1881,7 @@ static int spansion_read_cr_quad_enable(struct spi_nor *nor)
ret = spi_nor_read_sr(nor); ret = spi_nor_read_sr(nor);
if (ret < 0) { if (ret < 0) {
dev_err(dev, "error while reading status register\n"); dev_err(dev, "error while reading status register\n");
return -EINVAL; return ret;
} }
sr_cr[0] = ret; sr_cr[0] = ret;
...@@ -1932,7 +1931,7 @@ static int sr2_bit7_quad_enable(struct spi_nor *nor) ...@@ -1932,7 +1931,7 @@ static int sr2_bit7_quad_enable(struct spi_nor *nor)
ret = spi_nor_write_sr2(nor, sr2); ret = spi_nor_write_sr2(nor, sr2);
if (ret) { if (ret) {
dev_err(nor->dev, "error while writing status register 2\n"); dev_err(nor->dev, "error while writing status register 2\n");
return -EINVAL; return ret;
} }
ret = spi_nor_wait_till_ready(nor); ret = spi_nor_wait_till_ready(nor);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment