Commit 73810b77 authored by Johannes Berg's avatar Johannes Berg

cfg80211: use atomic_t for wiphy counter

There's no need to lock, we can just use an atomic_t.
Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent 9f419f38
...@@ -289,7 +289,7 @@ static void cfg80211_event_work(struct work_struct *work) ...@@ -289,7 +289,7 @@ static void cfg80211_event_work(struct work_struct *work)
struct wiphy *wiphy_new(const struct cfg80211_ops *ops, int sizeof_priv) struct wiphy *wiphy_new(const struct cfg80211_ops *ops, int sizeof_priv)
{ {
static int wiphy_counter; static atomic_t wiphy_counter = ATOMIC_INIT(0);
struct cfg80211_registered_device *rdev; struct cfg80211_registered_device *rdev;
int alloc_size; int alloc_size;
...@@ -311,20 +311,15 @@ struct wiphy *wiphy_new(const struct cfg80211_ops *ops, int sizeof_priv) ...@@ -311,20 +311,15 @@ struct wiphy *wiphy_new(const struct cfg80211_ops *ops, int sizeof_priv)
rdev->ops = ops; rdev->ops = ops;
mutex_lock(&cfg80211_mutex); rdev->wiphy_idx = atomic_inc_return(&wiphy_counter);
rdev->wiphy_idx = wiphy_counter++;
if (unlikely(rdev->wiphy_idx < 0)) { if (unlikely(rdev->wiphy_idx < 0)) {
wiphy_counter--;
mutex_unlock(&cfg80211_mutex);
/* ugh, wrapped! */ /* ugh, wrapped! */
atomic_dec(&wiphy_counter);
kfree(rdev); kfree(rdev);
return NULL; return NULL;
} }
mutex_unlock(&cfg80211_mutex);
/* give it a proper name */ /* give it a proper name */
dev_set_name(&rdev->wiphy.dev, PHY_NAME "%d", rdev->wiphy_idx); dev_set_name(&rdev->wiphy.dev, PHY_NAME "%d", rdev->wiphy_idx);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment