Commit 751281c5 authored by Benjamin Cheng's avatar Benjamin Cheng Committed by Alex Deucher

drm/amd/display: Write to correct dirty_rect

When FB_DAMAGE_CLIPS are provided in a non-MPO scenario, the loop does
not use the counter i. This causes the fill_dc_dity_rect() to always
fill dirty_rects[0], causing graphical artifacts when a damage clip
aware DRM client sends more than 1 damage clip.

Instead, use the flip_addrs->dirty_rect_count which is incremented by
fill_dc_dirty_rect() on a successful fill.

Fixes: 30ebe415 ("drm/amd/display: add FB_DAMAGE_CLIPS support")
Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/2453Signed-off-by: default avatarBenjamin Cheng <ben@bcheng.me>
Signed-off-by: default avatarHamza Mahfooz <hamza.mahfooz@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
Cc: stable@vger.kernel.org # 6.1.x
parent 3fadda5d
...@@ -5105,9 +5105,9 @@ static void fill_dc_dirty_rects(struct drm_plane *plane, ...@@ -5105,9 +5105,9 @@ static void fill_dc_dirty_rects(struct drm_plane *plane,
for (; flip_addrs->dirty_rect_count < num_clips; clips++) for (; flip_addrs->dirty_rect_count < num_clips; clips++)
fill_dc_dirty_rect(new_plane_state->plane, fill_dc_dirty_rect(new_plane_state->plane,
&dirty_rects[i], clips->x1, &dirty_rects[flip_addrs->dirty_rect_count],
clips->y1, clips->x2 - clips->x1, clips->x1, clips->y1,
clips->y2 - clips->y1, clips->x2 - clips->x1, clips->y2 - clips->y1,
&flip_addrs->dirty_rect_count, &flip_addrs->dirty_rect_count,
false); false);
return; return;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment