Commit 77006f6e authored by Serge Semin's avatar Serge Semin Committed by Bartosz Golaszewski

gpio: dwapb: Don't print error on -EPROBE_DEFER

Currently if the APB or Debounce clocks aren't yet ready to be requested
the DW GPIO driver will correctly handle that by deferring the probe
procedure, but the error is still printed to the system log. It needlessly
pollutes the log since there was no real error but a request to postpone
the clock request procedure since the clocks subsystem hasn't been fully
initialized yet. Let's fix that by using the dev_err_probe method to print
the APB/clock request error status. It will correctly handle the deferred
probe situation and print the error if it actually happens.
Signed-off-by: default avatarSerge Semin <Sergey.Semin@baikalelectronics.ru>
Reviewed-by: default avatarAndy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: default avatarBartosz Golaszewski <brgl@bgdev.pl>
parent 7219b824
...@@ -662,10 +662,9 @@ static int dwapb_get_clks(struct dwapb_gpio *gpio) ...@@ -662,10 +662,9 @@ static int dwapb_get_clks(struct dwapb_gpio *gpio)
gpio->clks[1].id = "db"; gpio->clks[1].id = "db";
err = devm_clk_bulk_get_optional(gpio->dev, DWAPB_NR_CLOCKS, err = devm_clk_bulk_get_optional(gpio->dev, DWAPB_NR_CLOCKS,
gpio->clks); gpio->clks);
if (err) { if (err)
dev_err(gpio->dev, "Cannot get APB/Debounce clocks\n"); return dev_err_probe(gpio->dev, err,
return err; "Cannot get APB/Debounce clocks\n");
}
err = clk_bulk_prepare_enable(DWAPB_NR_CLOCKS, gpio->clks); err = clk_bulk_prepare_enable(DWAPB_NR_CLOCKS, gpio->clks);
if (err) { if (err) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment