Commit 773aaadc authored by Colin Ian King's avatar Colin Ian King Committed by Boris Ostrovsky

xen/pvcalls: remove redundant check for irq >= 0

This is a moot point, but irq is always less than zero at the label
out_error, so the check for irq >= 0 is redundant and can be removed.

Detected by CoverityScan, CID#1460371 ("Logically dead code")

Fixes: cb1c7d9b ("xen/pvcalls: implement connect command")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Reviewed-by: default avatarJuergen Gross <jgross@suse.com>
Signed-off-by: default avatarBoris Ostrovsky <boris.ostrovsky@oracle.com>
parent 95110ac8
...@@ -351,9 +351,7 @@ static int create_active(struct sock_mapping *map, int *evtchn) ...@@ -351,9 +351,7 @@ static int create_active(struct sock_mapping *map, int *evtchn)
return 0; return 0;
out_error: out_error:
if (irq >= 0) if (*evtchn >= 0)
unbind_from_irqhandler(irq, map);
else if (*evtchn >= 0)
xenbus_free_evtchn(pvcalls_front_dev, *evtchn); xenbus_free_evtchn(pvcalls_front_dev, *evtchn);
kfree(map->active.data.in); kfree(map->active.data.in);
kfree(map->active.ring); kfree(map->active.ring);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment