Commit 786f847f authored by Christoph Hellwig's avatar Christoph Hellwig Committed by David Sterba

iomap: add per-iomap_iter private data

Allow the file system to keep state for all iterations.  For now only
wire it up for direct I/O as there is an immediate need for it there.
Reviewed-by: default avatarDarrick J. Wong <djwong@kernel.org>
Reviewed-by: default avatarNikolay Borisov <nborisov@suse.com>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent 908c5490
...@@ -8167,7 +8167,7 @@ static const struct iomap_dio_ops btrfs_dio_ops = { ...@@ -8167,7 +8167,7 @@ static const struct iomap_dio_ops btrfs_dio_ops = {
ssize_t btrfs_dio_rw(struct kiocb *iocb, struct iov_iter *iter, size_t done_before) ssize_t btrfs_dio_rw(struct kiocb *iocb, struct iov_iter *iter, size_t done_before)
{ {
return iomap_dio_rw(iocb, iter, &btrfs_dio_iomap_ops, &btrfs_dio_ops, return iomap_dio_rw(iocb, iter, &btrfs_dio_iomap_ops, &btrfs_dio_ops,
IOMAP_DIO_PARTIAL, done_before); IOMAP_DIO_PARTIAL, NULL, done_before);
} }
static int btrfs_fiemap(struct inode *inode, struct fiemap_extent_info *fieinfo, static int btrfs_fiemap(struct inode *inode, struct fiemap_extent_info *fieinfo,
......
...@@ -385,7 +385,7 @@ static ssize_t erofs_file_read_iter(struct kiocb *iocb, struct iov_iter *to) ...@@ -385,7 +385,7 @@ static ssize_t erofs_file_read_iter(struct kiocb *iocb, struct iov_iter *to)
if (!err) if (!err)
return iomap_dio_rw(iocb, to, &erofs_iomap_ops, return iomap_dio_rw(iocb, to, &erofs_iomap_ops,
NULL, 0, 0); NULL, 0, NULL, 0);
if (err < 0) if (err < 0)
return err; return err;
} }
......
...@@ -76,7 +76,7 @@ static ssize_t ext4_dio_read_iter(struct kiocb *iocb, struct iov_iter *to) ...@@ -76,7 +76,7 @@ static ssize_t ext4_dio_read_iter(struct kiocb *iocb, struct iov_iter *to)
return generic_file_read_iter(iocb, to); return generic_file_read_iter(iocb, to);
} }
ret = iomap_dio_rw(iocb, to, &ext4_iomap_ops, NULL, 0, 0); ret = iomap_dio_rw(iocb, to, &ext4_iomap_ops, NULL, 0, NULL, 0);
inode_unlock_shared(inode); inode_unlock_shared(inode);
file_accessed(iocb->ki_filp); file_accessed(iocb->ki_filp);
...@@ -565,7 +565,7 @@ static ssize_t ext4_dio_write_iter(struct kiocb *iocb, struct iov_iter *from) ...@@ -565,7 +565,7 @@ static ssize_t ext4_dio_write_iter(struct kiocb *iocb, struct iov_iter *from)
iomap_ops = &ext4_iomap_overwrite_ops; iomap_ops = &ext4_iomap_overwrite_ops;
ret = iomap_dio_rw(iocb, from, iomap_ops, &ext4_dio_write_ops, ret = iomap_dio_rw(iocb, from, iomap_ops, &ext4_dio_write_ops,
(unaligned_io || extend) ? IOMAP_DIO_FORCE_WAIT : 0, (unaligned_io || extend) ? IOMAP_DIO_FORCE_WAIT : 0,
0); NULL, 0);
if (ret == -ENOTBLK) if (ret == -ENOTBLK)
ret = 0; ret = 0;
......
...@@ -4309,7 +4309,7 @@ static ssize_t f2fs_dio_read_iter(struct kiocb *iocb, struct iov_iter *to) ...@@ -4309,7 +4309,7 @@ static ssize_t f2fs_dio_read_iter(struct kiocb *iocb, struct iov_iter *to)
*/ */
inc_page_count(sbi, F2FS_DIO_READ); inc_page_count(sbi, F2FS_DIO_READ);
dio = __iomap_dio_rw(iocb, to, &f2fs_iomap_ops, dio = __iomap_dio_rw(iocb, to, &f2fs_iomap_ops,
&f2fs_iomap_dio_read_ops, 0, 0); &f2fs_iomap_dio_read_ops, 0, NULL, 0);
if (IS_ERR_OR_NULL(dio)) { if (IS_ERR_OR_NULL(dio)) {
ret = PTR_ERR_OR_ZERO(dio); ret = PTR_ERR_OR_ZERO(dio);
if (ret != -EIOCBQUEUED) if (ret != -EIOCBQUEUED)
...@@ -4527,7 +4527,7 @@ static ssize_t f2fs_dio_write_iter(struct kiocb *iocb, struct iov_iter *from, ...@@ -4527,7 +4527,7 @@ static ssize_t f2fs_dio_write_iter(struct kiocb *iocb, struct iov_iter *from,
if (pos + count > inode->i_size) if (pos + count > inode->i_size)
dio_flags |= IOMAP_DIO_FORCE_WAIT; dio_flags |= IOMAP_DIO_FORCE_WAIT;
dio = __iomap_dio_rw(iocb, from, &f2fs_iomap_ops, dio = __iomap_dio_rw(iocb, from, &f2fs_iomap_ops,
&f2fs_iomap_dio_write_ops, dio_flags, 0); &f2fs_iomap_dio_write_ops, dio_flags, NULL, 0);
if (IS_ERR_OR_NULL(dio)) { if (IS_ERR_OR_NULL(dio)) {
ret = PTR_ERR_OR_ZERO(dio); ret = PTR_ERR_OR_ZERO(dio);
if (ret == -ENOTBLK) if (ret == -ENOTBLK)
......
...@@ -835,7 +835,7 @@ static ssize_t gfs2_file_direct_read(struct kiocb *iocb, struct iov_iter *to, ...@@ -835,7 +835,7 @@ static ssize_t gfs2_file_direct_read(struct kiocb *iocb, struct iov_iter *to,
pagefault_disable(); pagefault_disable();
to->nofault = true; to->nofault = true;
ret = iomap_dio_rw(iocb, to, &gfs2_iomap_ops, NULL, ret = iomap_dio_rw(iocb, to, &gfs2_iomap_ops, NULL,
IOMAP_DIO_PARTIAL, read); IOMAP_DIO_PARTIAL, NULL, read);
to->nofault = false; to->nofault = false;
pagefault_enable(); pagefault_enable();
if (ret <= 0 && ret != -EFAULT) if (ret <= 0 && ret != -EFAULT)
...@@ -898,7 +898,7 @@ static ssize_t gfs2_file_direct_write(struct kiocb *iocb, struct iov_iter *from, ...@@ -898,7 +898,7 @@ static ssize_t gfs2_file_direct_write(struct kiocb *iocb, struct iov_iter *from,
from->nofault = true; from->nofault = true;
ret = iomap_dio_rw(iocb, from, &gfs2_iomap_ops, NULL, ret = iomap_dio_rw(iocb, from, &gfs2_iomap_ops, NULL,
IOMAP_DIO_PARTIAL, written); IOMAP_DIO_PARTIAL, NULL, written);
from->nofault = false; from->nofault = false;
if (ret <= 0) { if (ret <= 0) {
if (ret == -ENOTBLK) if (ret == -ENOTBLK)
......
...@@ -483,7 +483,7 @@ static loff_t iomap_dio_iter(const struct iomap_iter *iter, ...@@ -483,7 +483,7 @@ static loff_t iomap_dio_iter(const struct iomap_iter *iter,
struct iomap_dio * struct iomap_dio *
__iomap_dio_rw(struct kiocb *iocb, struct iov_iter *iter, __iomap_dio_rw(struct kiocb *iocb, struct iov_iter *iter,
const struct iomap_ops *ops, const struct iomap_dio_ops *dops, const struct iomap_ops *ops, const struct iomap_dio_ops *dops,
unsigned int dio_flags, size_t done_before) unsigned int dio_flags, void *private, size_t done_before)
{ {
struct address_space *mapping = iocb->ki_filp->f_mapping; struct address_space *mapping = iocb->ki_filp->f_mapping;
struct inode *inode = file_inode(iocb->ki_filp); struct inode *inode = file_inode(iocb->ki_filp);
...@@ -492,6 +492,7 @@ __iomap_dio_rw(struct kiocb *iocb, struct iov_iter *iter, ...@@ -492,6 +492,7 @@ __iomap_dio_rw(struct kiocb *iocb, struct iov_iter *iter,
.pos = iocb->ki_pos, .pos = iocb->ki_pos,
.len = iov_iter_count(iter), .len = iov_iter_count(iter),
.flags = IOMAP_DIRECT, .flags = IOMAP_DIRECT,
.private = private,
}; };
loff_t end = iomi.pos + iomi.len - 1, ret = 0; loff_t end = iomi.pos + iomi.len - 1, ret = 0;
bool wait_for_completion = bool wait_for_completion =
...@@ -683,11 +684,12 @@ EXPORT_SYMBOL_GPL(__iomap_dio_rw); ...@@ -683,11 +684,12 @@ EXPORT_SYMBOL_GPL(__iomap_dio_rw);
ssize_t ssize_t
iomap_dio_rw(struct kiocb *iocb, struct iov_iter *iter, iomap_dio_rw(struct kiocb *iocb, struct iov_iter *iter,
const struct iomap_ops *ops, const struct iomap_dio_ops *dops, const struct iomap_ops *ops, const struct iomap_dio_ops *dops,
unsigned int dio_flags, size_t done_before) unsigned int dio_flags, void *private, size_t done_before)
{ {
struct iomap_dio *dio; struct iomap_dio *dio;
dio = __iomap_dio_rw(iocb, iter, ops, dops, dio_flags, done_before); dio = __iomap_dio_rw(iocb, iter, ops, dops, dio_flags, private,
done_before);
if (IS_ERR_OR_NULL(dio)) if (IS_ERR_OR_NULL(dio))
return PTR_ERR_OR_ZERO(dio); return PTR_ERR_OR_ZERO(dio);
return iomap_dio_complete(dio); return iomap_dio_complete(dio);
......
...@@ -225,7 +225,7 @@ xfs_file_dio_read( ...@@ -225,7 +225,7 @@ xfs_file_dio_read(
ret = xfs_ilock_iocb(iocb, XFS_IOLOCK_SHARED); ret = xfs_ilock_iocb(iocb, XFS_IOLOCK_SHARED);
if (ret) if (ret)
return ret; return ret;
ret = iomap_dio_rw(iocb, to, &xfs_read_iomap_ops, NULL, 0, 0); ret = iomap_dio_rw(iocb, to, &xfs_read_iomap_ops, NULL, 0, NULL, 0);
xfs_iunlock(ip, XFS_IOLOCK_SHARED); xfs_iunlock(ip, XFS_IOLOCK_SHARED);
return ret; return ret;
...@@ -534,7 +534,7 @@ xfs_file_dio_write_aligned( ...@@ -534,7 +534,7 @@ xfs_file_dio_write_aligned(
} }
trace_xfs_file_direct_write(iocb, from); trace_xfs_file_direct_write(iocb, from);
ret = iomap_dio_rw(iocb, from, &xfs_direct_write_iomap_ops, ret = iomap_dio_rw(iocb, from, &xfs_direct_write_iomap_ops,
&xfs_dio_write_ops, 0, 0); &xfs_dio_write_ops, 0, NULL, 0);
out_unlock: out_unlock:
if (iolock) if (iolock)
xfs_iunlock(ip, iolock); xfs_iunlock(ip, iolock);
...@@ -612,7 +612,7 @@ xfs_file_dio_write_unaligned( ...@@ -612,7 +612,7 @@ xfs_file_dio_write_unaligned(
trace_xfs_file_direct_write(iocb, from); trace_xfs_file_direct_write(iocb, from);
ret = iomap_dio_rw(iocb, from, &xfs_direct_write_iomap_ops, ret = iomap_dio_rw(iocb, from, &xfs_direct_write_iomap_ops,
&xfs_dio_write_ops, flags, 0); &xfs_dio_write_ops, flags, NULL, 0);
/* /*
* Retry unaligned I/O with exclusive blocking semantics if the DIO * Retry unaligned I/O with exclusive blocking semantics if the DIO
......
...@@ -861,7 +861,7 @@ static ssize_t zonefs_file_dio_write(struct kiocb *iocb, struct iov_iter *from) ...@@ -861,7 +861,7 @@ static ssize_t zonefs_file_dio_write(struct kiocb *iocb, struct iov_iter *from)
ret = zonefs_file_dio_append(iocb, from); ret = zonefs_file_dio_append(iocb, from);
else else
ret = iomap_dio_rw(iocb, from, &zonefs_iomap_ops, ret = iomap_dio_rw(iocb, from, &zonefs_iomap_ops,
&zonefs_write_dio_ops, 0, 0); &zonefs_write_dio_ops, 0, NULL, 0);
if (zi->i_ztype == ZONEFS_ZTYPE_SEQ && if (zi->i_ztype == ZONEFS_ZTYPE_SEQ &&
(ret > 0 || ret == -EIOCBQUEUED)) { (ret > 0 || ret == -EIOCBQUEUED)) {
if (ret > 0) if (ret > 0)
...@@ -996,7 +996,7 @@ static ssize_t zonefs_file_read_iter(struct kiocb *iocb, struct iov_iter *to) ...@@ -996,7 +996,7 @@ static ssize_t zonefs_file_read_iter(struct kiocb *iocb, struct iov_iter *to)
} }
file_accessed(iocb->ki_filp); file_accessed(iocb->ki_filp);
ret = iomap_dio_rw(iocb, to, &zonefs_iomap_ops, ret = iomap_dio_rw(iocb, to, &zonefs_iomap_ops,
&zonefs_read_dio_ops, 0, 0); &zonefs_read_dio_ops, 0, NULL, 0);
} else { } else {
ret = generic_file_read_iter(iocb, to); ret = generic_file_read_iter(iocb, to);
if (ret == -EIO) if (ret == -EIO)
......
...@@ -188,6 +188,7 @@ struct iomap_iter { ...@@ -188,6 +188,7 @@ struct iomap_iter {
unsigned flags; unsigned flags;
struct iomap iomap; struct iomap iomap;
struct iomap srcmap; struct iomap srcmap;
void *private;
}; };
int iomap_iter(struct iomap_iter *iter, const struct iomap_ops *ops); int iomap_iter(struct iomap_iter *iter, const struct iomap_ops *ops);
...@@ -354,10 +355,10 @@ struct iomap_dio_ops { ...@@ -354,10 +355,10 @@ struct iomap_dio_ops {
ssize_t iomap_dio_rw(struct kiocb *iocb, struct iov_iter *iter, ssize_t iomap_dio_rw(struct kiocb *iocb, struct iov_iter *iter,
const struct iomap_ops *ops, const struct iomap_dio_ops *dops, const struct iomap_ops *ops, const struct iomap_dio_ops *dops,
unsigned int dio_flags, size_t done_before); unsigned int dio_flags, void *private, size_t done_before);
struct iomap_dio *__iomap_dio_rw(struct kiocb *iocb, struct iov_iter *iter, struct iomap_dio *__iomap_dio_rw(struct kiocb *iocb, struct iov_iter *iter,
const struct iomap_ops *ops, const struct iomap_dio_ops *dops, const struct iomap_ops *ops, const struct iomap_dio_ops *dops,
unsigned int dio_flags, size_t done_before); unsigned int dio_flags, void *private, size_t done_before);
ssize_t iomap_dio_complete(struct iomap_dio *dio); ssize_t iomap_dio_complete(struct iomap_dio *dio);
void iomap_dio_bio_end_io(struct bio *bio); void iomap_dio_bio_end_io(struct bio *bio);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment