Commit 7966f2d2 authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman

staging: lustre/ptlrpc: small leak on allocation failure

We should free "desc" before returning NULL.
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarAndreas Dilger <andreas.dilger@intel.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 2d2139c5
...@@ -128,12 +128,12 @@ struct ptlrpc_bulk_desc *ptlrpc_new_bulk(unsigned int nfrags, ...@@ -128,12 +128,12 @@ struct ptlrpc_bulk_desc *ptlrpc_new_bulk(unsigned int nfrags,
GET_KIOV(desc) = kcalloc(nfrags, sizeof(*GET_KIOV(desc)), GET_KIOV(desc) = kcalloc(nfrags, sizeof(*GET_KIOV(desc)),
GFP_NOFS); GFP_NOFS);
if (!GET_KIOV(desc)) if (!GET_KIOV(desc))
goto out; goto free_desc;
} else { } else {
GET_KVEC(desc) = kcalloc(nfrags, sizeof(*GET_KVEC(desc)), GET_KVEC(desc) = kcalloc(nfrags, sizeof(*GET_KVEC(desc)),
GFP_NOFS); GFP_NOFS);
if (!GET_KVEC(desc)) if (!GET_KVEC(desc))
goto out; goto free_desc;
} }
spin_lock_init(&desc->bd_lock); spin_lock_init(&desc->bd_lock);
...@@ -154,7 +154,8 @@ struct ptlrpc_bulk_desc *ptlrpc_new_bulk(unsigned int nfrags, ...@@ -154,7 +154,8 @@ struct ptlrpc_bulk_desc *ptlrpc_new_bulk(unsigned int nfrags,
LNetInvalidateHandle(&desc->bd_mds[i]); LNetInvalidateHandle(&desc->bd_mds[i]);
return desc; return desc;
out: free_desc:
kfree(desc);
return NULL; return NULL;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment