Commit 7bc9ab0f authored by Qing Wang's avatar Qing Wang Committed by Marc Kleine-Budde

can: at91/janz-ican3: replace snprintf() in show functions with sysfs_emit()

The sysfs show() functions must not use snprintf() when formatting the
value to be returned to user space.

Fix the following coccicheck warning:
| drivers/net/can/at91_can.c:1185: WARNING: use scnprintf or sprintf.
| drivers/net/can/janz-ican3.c:1834: WARNING: use scnprintf or sprintf.
|
| Use sysfs_emit instead of scnprintf or sprintf makes more sense.

Link: https://lore.kernel.org/all/1634280624-4816-1-git-send-email-wangqing@vivo.comSigned-off-by: default avatarQing Wang <wangqing@vivo.com>
Signed-off-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
parent fa759a93
...@@ -1170,9 +1170,9 @@ static ssize_t mb0_id_show(struct device *dev, ...@@ -1170,9 +1170,9 @@ static ssize_t mb0_id_show(struct device *dev,
struct at91_priv *priv = netdev_priv(to_net_dev(dev)); struct at91_priv *priv = netdev_priv(to_net_dev(dev));
if (priv->mb0_id & CAN_EFF_FLAG) if (priv->mb0_id & CAN_EFF_FLAG)
return snprintf(buf, PAGE_SIZE, "0x%08x\n", priv->mb0_id); return sysfs_emit(buf, "0x%08x\n", priv->mb0_id);
else else
return snprintf(buf, PAGE_SIZE, "0x%03x\n", priv->mb0_id); return sysfs_emit(buf, "0x%03x\n", priv->mb0_id);
} }
static ssize_t mb0_id_store(struct device *dev, static ssize_t mb0_id_store(struct device *dev,
......
...@@ -1831,7 +1831,7 @@ static ssize_t termination_show(struct device *dev, ...@@ -1831,7 +1831,7 @@ static ssize_t termination_show(struct device *dev,
return -ETIMEDOUT; return -ETIMEDOUT;
} }
return snprintf(buf, PAGE_SIZE, "%u\n", mod->termination_enabled); return sysfs_emit(buf, "%u\n", mod->termination_enabled);
} }
static ssize_t termination_store(struct device *dev, static ssize_t termination_store(struct device *dev,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment