Commit 7c02f6ae authored by Shannon Nelson's avatar Shannon Nelson Committed by Jakub Kicinski

pds_core: fix up some format-truncation complaints

Our friendly kernel test robot pointed out a couple of potential
string truncation issues.  None of which were we worried about,
but can be relatively easily fixed to quiet the complaints.
Reported-by: default avatarkernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202310211736.66syyDpp-lkp@intel.com/
Fixes: 45d76f49 ("pds_core: set up device and adminq")
Signed-off-by: default avatarShannon Nelson <shannon.nelson@amd.com>
Link: https://lore.kernel.org/r/20231113183257.71110-3-shannon.nelson@amd.comSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 09d4c14c
...@@ -15,7 +15,7 @@ ...@@ -15,7 +15,7 @@
#define PDSC_DRV_DESCRIPTION "AMD/Pensando Core Driver" #define PDSC_DRV_DESCRIPTION "AMD/Pensando Core Driver"
#define PDSC_WATCHDOG_SECS 5 #define PDSC_WATCHDOG_SECS 5
#define PDSC_QUEUE_NAME_MAX_SZ 32 #define PDSC_QUEUE_NAME_MAX_SZ 16
#define PDSC_ADMINQ_MIN_LENGTH 16 /* must be a power of two */ #define PDSC_ADMINQ_MIN_LENGTH 16 /* must be a power of two */
#define PDSC_NOTIFYQ_LENGTH 64 /* must be a power of two */ #define PDSC_NOTIFYQ_LENGTH 64 /* must be a power of two */
#define PDSC_TEARDOWN_RECOVERY false #define PDSC_TEARDOWN_RECOVERY false
......
...@@ -261,10 +261,14 @@ static int pdsc_identify(struct pdsc *pdsc) ...@@ -261,10 +261,14 @@ static int pdsc_identify(struct pdsc *pdsc)
struct pds_core_drv_identity drv = {}; struct pds_core_drv_identity drv = {};
size_t sz; size_t sz;
int err; int err;
int n;
drv.drv_type = cpu_to_le32(PDS_DRIVER_LINUX); drv.drv_type = cpu_to_le32(PDS_DRIVER_LINUX);
snprintf(drv.driver_ver_str, sizeof(drv.driver_ver_str), /* Catching the return quiets a Wformat-truncation complaint */
"%s %s", PDS_CORE_DRV_NAME, utsname()->release); n = snprintf(drv.driver_ver_str, sizeof(drv.driver_ver_str),
"%s %s", PDS_CORE_DRV_NAME, utsname()->release);
if (n > sizeof(drv.driver_ver_str))
dev_dbg(pdsc->dev, "release name truncated, don't care\n");
/* Next let's get some info about the device /* Next let's get some info about the device
* We use the devcmd_lock at this level in order to * We use the devcmd_lock at this level in order to
......
...@@ -104,7 +104,7 @@ int pdsc_dl_info_get(struct devlink *dl, struct devlink_info_req *req, ...@@ -104,7 +104,7 @@ int pdsc_dl_info_get(struct devlink *dl, struct devlink_info_req *req,
struct pds_core_fw_list_info fw_list; struct pds_core_fw_list_info fw_list;
struct pdsc *pdsc = devlink_priv(dl); struct pdsc *pdsc = devlink_priv(dl);
union pds_core_dev_comp comp; union pds_core_dev_comp comp;
char buf[16]; char buf[32];
int listlen; int listlen;
int err; int err;
int i; int i;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment