Commit 7c4c72f4 authored by Peter Senna Tschudin's avatar Peter Senna Tschudin Committed by Florian Tobias Schandinat

drivers/video/cyber2000fb.c: fix error return code

Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}
// </smpl>
Signed-off-by: default avatarPeter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: default avatarFlorian Tobias Schandinat <FlorianSchandinat@gmx.de>
parent 0ca30b1b
...@@ -1804,8 +1804,10 @@ cyberpro_pci_probe(struct pci_dev *dev, const struct pci_device_id *id) ...@@ -1804,8 +1804,10 @@ cyberpro_pci_probe(struct pci_dev *dev, const struct pci_device_id *id)
cfb->irq = dev->irq; cfb->irq = dev->irq;
cfb->region = pci_ioremap_bar(dev, 0); cfb->region = pci_ioremap_bar(dev, 0);
if (!cfb->region) if (!cfb->region) {
err = -ENOMEM;
goto failed_ioremap; goto failed_ioremap;
}
cfb->regs = cfb->region + MMIO_OFFSET; cfb->regs = cfb->region + MMIO_OFFSET;
cfb->fb.device = &dev->dev; cfb->fb.device = &dev->dev;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment