Commit 7c77b7f1 authored by Kees Cook's avatar Kees Cook Committed by Jiri Slaby

firmware_class: make sure fw requests contain a name

commit 471b095d upstream.

An empty firmware request name will trigger warnings when building
device names. Make sure this is caught earlier and rejected.

The warning was visible via the test_firmware.ko module interface:

echo -ne "\x00" > /sys/devices/virtual/misc/test_firmware/trigger_request
Reported-by: default avatarSasha Levin <sasha.levin@oracle.com>
Signed-off-by: default avatarKees Cook <keescook@chromium.org>
Tested-by: default avatarSasha Levin <sasha.levin@oracle.com>
Signed-off-by: default avatarJiri Slaby <jslaby@suse.cz>
parent 9235aef1
......@@ -1063,6 +1063,9 @@ _request_firmware(const struct firmware **firmware_p, const char *name,
if (!firmware_p)
return -EINVAL;
if (!name || name[0] == '\0')
return -EINVAL;
ret = _request_firmware_prepare(&fw, name, device);
if (ret <= 0) /* error or already assigned */
goto out;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment