Commit 7f62cf78 authored by Liang He's avatar Liang He Committed by Guenter Roeck

hwmon: (gsc-hwmon) Call of_node_get() before of_find_xxx API

In gsc_hwmon_get_devtree_pdata(), we should call of_node_get() before
the of_find_compatible_node() which will automatically call
of_node_put() for the 'from' argument.

Fixes: 3bce5377 ("hwmon: Add Gateworks System Controller support")
Signed-off-by: default avatarLiang He <windhl@126.com>
Co-developed-by: default avatarMengda Chen <chenmengda2009@163.com>
Signed-off-by: default avatarMengda Chen <chenmengda2009@163.com>
Link: https://lore.kernel.org/r/20220916154708.3084515-1-chenmengda2009@163.com
Cc: stable@vger.kernel.org
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent b7f3e965
...@@ -267,6 +267,7 @@ gsc_hwmon_get_devtree_pdata(struct device *dev) ...@@ -267,6 +267,7 @@ gsc_hwmon_get_devtree_pdata(struct device *dev)
pdata->nchannels = nchannels; pdata->nchannels = nchannels;
/* fan controller base address */ /* fan controller base address */
of_node_get(dev->parent->of_node);
fan = of_find_compatible_node(dev->parent->of_node, NULL, "gw,gsc-fan"); fan = of_find_compatible_node(dev->parent->of_node, NULL, "gw,gsc-fan");
if (fan && of_property_read_u32(fan, "reg", &pdata->fan_base)) { if (fan && of_property_read_u32(fan, "reg", &pdata->fan_base)) {
of_node_put(fan); of_node_put(fan);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment