Commit 7fb0728a authored by Mike Kravetz's avatar Mike Kravetz Committed by Andrew Morton

hugetlb: fix __prep_compound_gigantic_page page flag setting

Commit 2b21624f ("hugetlb: freeze allocated pages before creating
hugetlb pages") changed the order page flags were cleared and set in the
head page.  It moved the __ClearPageReserved after __SetPageHead. 
However, there is a check to make sure __ClearPageReserved is never done
on a head page.  If CONFIG_DEBUG_VM_PGFLAGS is enabled, the following BUG
will be hit when creating a hugetlb gigantic page:

    page dumped because: VM_BUG_ON_PAGE(1 && PageCompound(page))
    ------------[ cut here ]------------
    kernel BUG at include/linux/page-flags.h:500!
    Call Trace will differ depending on whether hugetlb page is created
    at boot time or run time.

Make sure to __ClearPageReserved BEFORE __SetPageHead.

Link: https://lkml.kernel.org/r/20221118195249.178319-1-mike.kravetz@oracle.com
Fixes: 2b21624f ("hugetlb: freeze allocated pages before creating hugetlb pages")
Signed-off-by: default avatarMike Kravetz <mike.kravetz@oracle.com>
Reported-by: default avatarAneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
Acked-by: default avatarMuchun Song <songmuchun@bytedance.com>
Tested-by: default avatarTarun Sahu <tsahu@linux.ibm.com>
Reviewed-by: default avatarMiaohe Lin <linmiaohe@huawei.com>
Cc: Joao Martins <joao.m.martins@oracle.com>
Cc: Matthew Wilcox <willy@infradead.org>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Naoya Horiguchi <naoya.horiguchi@nec.com>
Cc: Oscar Salvador <osalvador@suse.de>
Cc: Peter Xu <peterx@redhat.com>
Cc: Sidhartha Kumar <sidhartha.kumar@oracle.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 747c0f35
...@@ -1800,6 +1800,7 @@ static bool __prep_compound_gigantic_page(struct page *page, unsigned int order, ...@@ -1800,6 +1800,7 @@ static bool __prep_compound_gigantic_page(struct page *page, unsigned int order,
/* we rely on prep_new_huge_page to set the destructor */ /* we rely on prep_new_huge_page to set the destructor */
set_compound_order(page, order); set_compound_order(page, order);
__ClearPageReserved(page);
__SetPageHead(page); __SetPageHead(page);
for (i = 0; i < nr_pages; i++) { for (i = 0; i < nr_pages; i++) {
p = nth_page(page, i); p = nth_page(page, i);
...@@ -1816,7 +1817,8 @@ static bool __prep_compound_gigantic_page(struct page *page, unsigned int order, ...@@ -1816,7 +1817,8 @@ static bool __prep_compound_gigantic_page(struct page *page, unsigned int order,
* on the head page when they need know if put_page() is needed * on the head page when they need know if put_page() is needed
* after get_user_pages(). * after get_user_pages().
*/ */
__ClearPageReserved(p); if (i != 0) /* head page cleared above */
__ClearPageReserved(p);
/* /*
* Subtle and very unlikely * Subtle and very unlikely
* *
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment