Commit 84b14256 authored by Zhen Lei's avatar Zhen Lei Committed by Will Deacon

of/numa: fix a memory@ node can only contains one memory block

For a normal memory@ devicetree node, its reg property can contains more
memory blocks.

Because we don't known how many memory blocks maybe contained, so we try
from index=0, increase 1 until error returned(the end).
Signed-off-by: default avatarZhen Lei <thunder.leizhen@huawei.com>
Acked-by: default avatarRob Herring <robh@kernel.org>
Signed-off-by: default avatarWill Deacon <will.deacon@arm.com>
parent 16a82f06
...@@ -63,13 +63,9 @@ static int __init of_numa_parse_memory_nodes(void) ...@@ -63,13 +63,9 @@ static int __init of_numa_parse_memory_nodes(void)
struct device_node *np = NULL; struct device_node *np = NULL;
struct resource rsrc; struct resource rsrc;
u32 nid; u32 nid;
int r = 0; int i, r;
for (;;) {
np = of_find_node_by_type(np, "memory");
if (!np)
break;
for_each_node_by_type(np, "memory") {
r = of_property_read_u32(np, "numa-node-id", &nid); r = of_property_read_u32(np, "numa-node-id", &nid);
if (r == -EINVAL) if (r == -EINVAL)
/* /*
...@@ -78,23 +74,18 @@ static int __init of_numa_parse_memory_nodes(void) ...@@ -78,23 +74,18 @@ static int __init of_numa_parse_memory_nodes(void)
* "numa-node-id" property * "numa-node-id" property
*/ */
continue; continue;
else if (r)
/* some other error */
break;
r = of_address_to_resource(np, 0, &rsrc); for (i = 0; !r && !of_address_to_resource(np, i, &rsrc); i++)
if (r) { r = numa_add_memblk(nid, rsrc.start, rsrc.end + 1);
pr_err("NUMA: bad reg property in memory node\n");
break;
}
r = numa_add_memblk(nid, rsrc.start, rsrc.end + 1); if (!i || r) {
if (r) of_node_put(np);
break; pr_err("NUMA: bad property in memory node\n");
return r ? : -EINVAL;
}
} }
of_node_put(np);
return r; return 0;
} }
static int __init of_numa_parse_distance_map_v1(struct device_node *map) static int __init of_numa_parse_distance_map_v1(struct device_node *map)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment