Commit 8537b1e0 authored by Takashi Sakamoto's avatar Takashi Sakamoto Committed by Greg Kroah-Hartman

ALSA: firewire-motu: destroy stream data surely at failure of card initialization

commit dbd7396b upstream.

When failing sound card registration after initializing stream data, this
module leaves allocated data in stream data. This commit fixes the bug.

Fixes: 9b2bb4f2 ('ALSA: firewire-motu: add stream management functionality')
Signed-off-by: default avatarTakashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 59d00061
...@@ -128,6 +128,7 @@ static void do_registration(struct work_struct *work) ...@@ -128,6 +128,7 @@ static void do_registration(struct work_struct *work)
return; return;
error: error:
snd_motu_transaction_unregister(motu); snd_motu_transaction_unregister(motu);
snd_motu_stream_destroy_duplex(motu);
snd_card_free(motu->card); snd_card_free(motu->card);
dev_info(&motu->unit->device, dev_info(&motu->unit->device,
"Sound card registration failed: %d\n", err); "Sound card registration failed: %d\n", err);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment