Commit 866e48b0 authored by Axel Lin's avatar Axel Lin Committed by Mark Brown

spi: pic32: Fix checking return value of devm_ioremap_resource

devm_ioremap_resource() returns ERR_PTR on error.
Also remove the redundant dev_err message, the implementation of
devm_ioremap_resource() already print error messages on error paths.
Signed-off-by: default avatarAxel Lin <axel.lin@ingics.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 2452ee25
...@@ -711,10 +711,9 @@ static int pic32_spi_hw_probe(struct platform_device *pdev, ...@@ -711,10 +711,9 @@ static int pic32_spi_hw_probe(struct platform_device *pdev,
mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
pic32s->regs = devm_ioremap_resource(&pdev->dev, mem); pic32s->regs = devm_ioremap_resource(&pdev->dev, mem);
if (!pic32s->regs) { if (IS_ERR(pic32s->regs))
dev_err(&pdev->dev, "ioremap() failed\n"); return PTR_ERR(pic32s->regs);
return -ENOMEM;
}
pic32s->dma_base = mem->start; pic32s->dma_base = mem->start;
/* get irq resources: err-irq, rx-irq, tx-irq */ /* get irq resources: err-irq, rx-irq, tx-irq */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment