Commit 8745465e authored by Javier Carrasco's avatar Javier Carrasco Committed by Jonathan Cameron

iio: light: as73211: use IIO_VAL_FRACTIONAL for intensity scales

The scale values associated to the light channels are calculated as a
division that can be better expressed as an IIO_VAL_FRACTIONAL type
instead of the current IIO_VAL_INT.

Note that the constant values used for the calculation were scaled up to
work with integers, turning the nW/cm^2 units from the datasheet into
nW/m^2, which would not be necessary with the IIO_VAL_FRACTIONAL type.
But to avoid issues from current users of the driver, the units must be
kept.
Signed-off-by: default avatarJavier Carrasco <javier.carrasco.cruz@gmail.com>
Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent 6613476e
...@@ -356,25 +356,24 @@ static int as73211_read_raw(struct iio_dev *indio_dev, struct iio_chan_spec cons ...@@ -356,25 +356,24 @@ static int as73211_read_raw(struct iio_dev *indio_dev, struct iio_chan_spec cons
return IIO_VAL_INT_PLUS_MICRO; return IIO_VAL_INT_PLUS_MICRO;
case IIO_INTENSITY: { case IIO_INTENSITY: {
unsigned int scale;
switch (chan->channel2) { switch (chan->channel2) {
case IIO_MOD_X: case IIO_MOD_X:
scale = AS73211_SCALE_X; *val = AS73211_SCALE_X;
break; break;
case IIO_MOD_Y: case IIO_MOD_Y:
scale = AS73211_SCALE_Y; *val = AS73211_SCALE_Y;
break; break;
case IIO_MOD_Z: case IIO_MOD_Z:
scale = AS73211_SCALE_Z; *val = AS73211_SCALE_Z;
break; break;
default: default:
return -EINVAL; return -EINVAL;
} }
scale /= as73211_gain(data); *val2 = as73211_integration_time_1024cyc(data) *
scale /= as73211_integration_time_1024cyc(data); as73211_gain(data);
*val = scale;
return IIO_VAL_INT; return IIO_VAL_FRACTIONAL;
default: default:
return -EINVAL; return -EINVAL;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment