Commit 87975a01 authored by Joel Stanley's avatar Joel Stanley Committed by David S. Miller

net/ncsi: Silence debug messages

In normal operation we see this series of messages as the host drives
the network device:

 ftgmac100 1e660000.ethernet eth0: NCSI: LSC AEN - channel 0 state down
 ftgmac100 1e660000.ethernet eth0: NCSI: suspending channel 0
 ftgmac100 1e660000.ethernet eth0: NCSI: configuring channel 0
 ftgmac100 1e660000.ethernet eth0: NCSI: channel 0 link down after config
 ftgmac100 1e660000.ethernet eth0: NCSI interface down
 ftgmac100 1e660000.ethernet eth0: NCSI: LSC AEN - channel 0 state up
 ftgmac100 1e660000.ethernet eth0: NCSI: configuring channel 0
 ftgmac100 1e660000.ethernet eth0: NCSI interface up
 ftgmac100 1e660000.ethernet eth0: NCSI: LSC AEN - channel 0 state down
 ftgmac100 1e660000.ethernet eth0: NCSI: suspending channel 0
 ftgmac100 1e660000.ethernet eth0: NCSI: configuring channel 0
 ftgmac100 1e660000.ethernet eth0: NCSI: channel 0 link down after config
 ftgmac100 1e660000.ethernet eth0: NCSI interface down
 ftgmac100 1e660000.ethernet eth0: NCSI: LSC AEN - channel 0 state up
 ftgmac100 1e660000.ethernet eth0: NCSI: configuring channel 0
 ftgmac100 1e660000.ethernet eth0: NCSI interface up

This makes all of these messages netdev_dbg. They are still useful to
debug eg. misbehaving network device firmware, but we do not need them
filling up the kernel logs in normal operation.
Acked-by: default avatarSamuel Mendoza-Jonas <sam@mendozajonas.com>
Signed-off-by: default avatarJoel Stanley <joel@jms.id.au>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent c51818d5
...@@ -1735,8 +1735,8 @@ static void ftgmac100_ncsi_handler(struct ncsi_dev *nd) ...@@ -1735,8 +1735,8 @@ static void ftgmac100_ncsi_handler(struct ncsi_dev *nd)
if (unlikely(nd->state != ncsi_dev_state_functional)) if (unlikely(nd->state != ncsi_dev_state_functional))
return; return;
netdev_info(nd->dev, "NCSI interface %s\n", netdev_dbg(nd->dev, "NCSI interface %s\n",
nd->link_up ? "up" : "down"); nd->link_up ? "up" : "down");
} }
static void ftgmac100_setup_clk(struct ftgmac100 *priv) static void ftgmac100_setup_clk(struct ftgmac100 *priv)
......
...@@ -73,8 +73,8 @@ static int ncsi_aen_handler_lsc(struct ncsi_dev_priv *ndp, ...@@ -73,8 +73,8 @@ static int ncsi_aen_handler_lsc(struct ncsi_dev_priv *ndp,
ncm->data[2] = data; ncm->data[2] = data;
ncm->data[4] = ntohl(lsc->oem_status); ncm->data[4] = ntohl(lsc->oem_status);
netdev_info(ndp->ndev.dev, "NCSI: LSC AEN - channel %u state %s\n", netdev_dbg(ndp->ndev.dev, "NCSI: LSC AEN - channel %u state %s\n",
nc->id, data & 0x1 ? "up" : "down"); nc->id, data & 0x1 ? "up" : "down");
chained = !list_empty(&nc->link); chained = !list_empty(&nc->link);
state = nc->state; state = nc->state;
......
...@@ -816,9 +816,9 @@ static void ncsi_configure_channel(struct ncsi_dev_priv *ndp) ...@@ -816,9 +816,9 @@ static void ncsi_configure_channel(struct ncsi_dev_priv *ndp)
} else { } else {
hot_nc = NULL; hot_nc = NULL;
nc->state = NCSI_CHANNEL_INACTIVE; nc->state = NCSI_CHANNEL_INACTIVE;
netdev_warn(ndp->ndev.dev, netdev_dbg(ndp->ndev.dev,
"NCSI: channel %u link down after config\n", "NCSI: channel %u link down after config\n",
nc->id); nc->id);
} }
spin_unlock_irqrestore(&nc->lock, flags); spin_unlock_irqrestore(&nc->lock, flags);
...@@ -1199,14 +1199,14 @@ int ncsi_process_next_channel(struct ncsi_dev_priv *ndp) ...@@ -1199,14 +1199,14 @@ int ncsi_process_next_channel(struct ncsi_dev_priv *ndp)
switch (old_state) { switch (old_state) {
case NCSI_CHANNEL_INACTIVE: case NCSI_CHANNEL_INACTIVE:
ndp->ndev.state = ncsi_dev_state_config; ndp->ndev.state = ncsi_dev_state_config;
netdev_info(ndp->ndev.dev, "NCSI: configuring channel %u\n", netdev_dbg(ndp->ndev.dev, "NCSI: configuring channel %u\n",
nc->id); nc->id);
ncsi_configure_channel(ndp); ncsi_configure_channel(ndp);
break; break;
case NCSI_CHANNEL_ACTIVE: case NCSI_CHANNEL_ACTIVE:
ndp->ndev.state = ncsi_dev_state_suspend; ndp->ndev.state = ncsi_dev_state_suspend;
netdev_info(ndp->ndev.dev, "NCSI: suspending channel %u\n", netdev_dbg(ndp->ndev.dev, "NCSI: suspending channel %u\n",
nc->id); nc->id);
ncsi_suspend_channel(ndp); ncsi_suspend_channel(ndp);
break; break;
default: default:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment