Commit 88428cc4 authored by Olga Kornievskaia's avatar Olga Kornievskaia Committed by Anna Schumaker

SUNRPC dont update timeout value on connection reset

Current behaviour: every time a v3 operation is re-sent to the server
we update (double) the timeout. There is no distinction between whether
or not the previous timer had expired before the re-sent happened.

Here's the scenario:
1. Client sends a v3 operation
2. Server RST-s the connection (prior to the timeout) (eg., connection
is immediately reset)
3. Client re-sends a v3 operation but the timeout is now 120sec.

As a result, an application sees 2mins pause before a retry in case
server again does not reply. Where as if a connection reset didn't
change the timeout value, the client would have re-tried (the 3rd
time) after 60secs.
Signed-off-by: default avatarOlga Kornievskaia <kolga@netapp.com>
Signed-off-by: default avatarAnna Schumaker <Anna.Schumaker@Netapp.com>
parent 82c596eb
...@@ -2405,7 +2405,8 @@ call_status(struct rpc_task *task) ...@@ -2405,7 +2405,8 @@ call_status(struct rpc_task *task)
goto out_exit; goto out_exit;
} }
task->tk_action = call_encode; task->tk_action = call_encode;
rpc_check_timeout(task); if (status != -ECONNRESET && status != -ECONNABORTED)
rpc_check_timeout(task);
return; return;
out_exit: out_exit:
rpc_call_rpcerror(task, status); rpc_call_rpcerror(task, status);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment