Commit 898a2f38 authored by Laurent Pinchart's avatar Laurent Pinchart

drm: rcar-du: Convert rcar_du_encoders_init_one() return value to 0/<0

The function returns 1 on success, and either 0 or a negative error code
on failure. As the 0 and negative values don't need to be differentiated
by the caller, convert it to the usual scheme of returning 0 on success
and a negative error code on failure.
Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
parent 64549cdf
...@@ -573,7 +573,7 @@ static int rcar_du_encoders_init_one(struct rcar_du_device *rcdu, ...@@ -573,7 +573,7 @@ static int rcar_du_encoders_init_one(struct rcar_du_device *rcdu,
if (!entity) { if (!entity) {
dev_dbg(rcdu->dev, "unconnected endpoint %s, skipping\n", dev_dbg(rcdu->dev, "unconnected endpoint %s, skipping\n",
ep->local_node->full_name); ep->local_node->full_name);
return 0; return -ENODEV;
} }
entity_ep_node = of_parse_phandle(ep->local_node, "remote-endpoint", 0); entity_ep_node = of_parse_phandle(ep->local_node, "remote-endpoint", 0);
...@@ -596,7 +596,7 @@ static int rcar_du_encoders_init_one(struct rcar_du_device *rcdu, ...@@ -596,7 +596,7 @@ static int rcar_du_encoders_init_one(struct rcar_du_device *rcdu,
encoder->full_name); encoder->full_name);
of_node_put(entity_ep_node); of_node_put(entity_ep_node);
of_node_put(encoder); of_node_put(encoder);
return 0; return -ENODEV;
} }
break; break;
...@@ -625,7 +625,7 @@ static int rcar_du_encoders_init_one(struct rcar_du_device *rcdu, ...@@ -625,7 +625,7 @@ static int rcar_du_encoders_init_one(struct rcar_du_device *rcdu,
encoder->full_name); encoder->full_name);
of_node_put(encoder); of_node_put(encoder);
of_node_put(connector); of_node_put(connector);
return 0; return -EINVAL;
} }
} else { } else {
/* /*
...@@ -644,7 +644,7 @@ static int rcar_du_encoders_init_one(struct rcar_du_device *rcdu, ...@@ -644,7 +644,7 @@ static int rcar_du_encoders_init_one(struct rcar_du_device *rcdu,
"failed to initialize encoder %s (%d), skipping\n", "failed to initialize encoder %s (%d), skipping\n",
encoder->full_name, ret); encoder->full_name, ret);
return ret < 0 ? ret : 1; return ret;
} }
static int rcar_du_encoders_init(struct rcar_du_device *rcdu) static int rcar_du_encoders_init(struct rcar_du_device *rcdu)
...@@ -696,7 +696,7 @@ static int rcar_du_encoders_init(struct rcar_du_device *rcdu) ...@@ -696,7 +696,7 @@ static int rcar_du_encoders_init(struct rcar_du_device *rcdu)
continue; continue;
} }
num_encoders += ret; num_encoders++;
} }
return num_encoders; return num_encoders;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment