Commit 8c0d44e2 authored by Ezequiel Garcia's avatar Ezequiel Garcia Committed by Mauro Carvalho Chehab

[media] uvcvideo: Replace memcpy with struct assignment

This kind of memcpy() is error-prone. Its replacement with a struct
assignment is prefered because it's type-safe and much easier to read.
Signed-off-by: default avatarPeter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: default avatarEzequiel Garcia <elezegarcia@gmail.com>
Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 5d97046a
...@@ -1838,7 +1838,7 @@ static int uvc_ctrl_add_info(struct uvc_device *dev, struct uvc_control *ctrl, ...@@ -1838,7 +1838,7 @@ static int uvc_ctrl_add_info(struct uvc_device *dev, struct uvc_control *ctrl,
{ {
int ret = 0; int ret = 0;
memcpy(&ctrl->info, info, sizeof(*info)); ctrl->info = *info;
INIT_LIST_HEAD(&ctrl->info.mappings); INIT_LIST_HEAD(&ctrl->info.mappings);
/* Allocate an array to save control values (cur, def, max, etc.) */ /* Allocate an array to save control values (cur, def, max, etc.) */
......
...@@ -315,7 +315,7 @@ static int uvc_v4l2_set_format(struct uvc_streaming *stream, ...@@ -315,7 +315,7 @@ static int uvc_v4l2_set_format(struct uvc_streaming *stream,
goto done; goto done;
} }
memcpy(&stream->ctrl, &probe, sizeof probe); stream->ctrl = probe;
stream->cur_format = format; stream->cur_format = format;
stream->cur_frame = frame; stream->cur_frame = frame;
...@@ -387,7 +387,7 @@ static int uvc_v4l2_set_streamparm(struct uvc_streaming *stream, ...@@ -387,7 +387,7 @@ static int uvc_v4l2_set_streamparm(struct uvc_streaming *stream,
return -EBUSY; return -EBUSY;
} }
memcpy(&probe, &stream->ctrl, sizeof probe); probe = stream->ctrl;
probe.dwFrameInterval = probe.dwFrameInterval =
uvc_try_frame_interval(stream->cur_frame, interval); uvc_try_frame_interval(stream->cur_frame, interval);
...@@ -398,7 +398,7 @@ static int uvc_v4l2_set_streamparm(struct uvc_streaming *stream, ...@@ -398,7 +398,7 @@ static int uvc_v4l2_set_streamparm(struct uvc_streaming *stream,
return ret; return ret;
} }
memcpy(&stream->ctrl, &probe, sizeof probe); stream->ctrl = probe;
mutex_unlock(&stream->mutex); mutex_unlock(&stream->mutex);
/* Return the actual frame period. */ /* Return the actual frame period. */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment