Commit 8f63a840 authored by Su Yue's avatar Su Yue Committed by David Sterba

btrfs: switch order of unlocks of space_info and bg in do_trimming()

In function do_trimming(), block_group->lock should be unlocked first,
as the locks should be released in the reverse order. This does not
cause problems but should follow the best practices.
Reviewed-by: default avatarNikolay Borisov <nborisov@suse.com>
Signed-off-by: default avatarSu Yue <suy.fnst@cn.fujitsu.com>
Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
[ update changelog ]
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent 4c094c33
...@@ -3166,8 +3166,8 @@ static int do_trimming(struct btrfs_block_group_cache *block_group, ...@@ -3166,8 +3166,8 @@ static int do_trimming(struct btrfs_block_group_cache *block_group,
space_info->bytes_readonly += reserved_bytes; space_info->bytes_readonly += reserved_bytes;
block_group->reserved -= reserved_bytes; block_group->reserved -= reserved_bytes;
space_info->bytes_reserved -= reserved_bytes; space_info->bytes_reserved -= reserved_bytes;
spin_unlock(&space_info->lock);
spin_unlock(&block_group->lock); spin_unlock(&block_group->lock);
spin_unlock(&space_info->lock);
} }
return ret; return ret;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment