Commit 9557b437 authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Lee Jones

leds: qcom-lpg: Simplify with scoped for each OF child loop

Use scoped for_each_available_child_of_node_scoped() when iterating over
device nodes to make code a bit simpler.
Signed-off-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20240816-cleanup-h-of-node-put-var-v1-17-1d0292802470@linaro.orgSigned-off-by: default avatarLee Jones <lee@kernel.org>
parent 122d57e2
...@@ -1368,7 +1368,6 @@ static int lpg_add_led(struct lpg *lpg, struct device_node *np) ...@@ -1368,7 +1368,6 @@ static int lpg_add_led(struct lpg *lpg, struct device_node *np)
{ {
struct led_init_data init_data = {}; struct led_init_data init_data = {};
struct led_classdev *cdev; struct led_classdev *cdev;
struct device_node *child;
struct mc_subled *info; struct mc_subled *info;
struct lpg_led *led; struct lpg_led *led;
const char *state; const char *state;
...@@ -1399,12 +1398,10 @@ static int lpg_add_led(struct lpg *lpg, struct device_node *np) ...@@ -1399,12 +1398,10 @@ static int lpg_add_led(struct lpg *lpg, struct device_node *np)
if (!info) if (!info)
return -ENOMEM; return -ENOMEM;
i = 0; i = 0;
for_each_available_child_of_node(np, child) { for_each_available_child_of_node_scoped(np, child) {
ret = lpg_parse_channel(lpg, child, &led->channels[i]); ret = lpg_parse_channel(lpg, child, &led->channels[i]);
if (ret < 0) { if (ret < 0)
of_node_put(child);
return ret; return ret;
}
info[i].color_index = led->channels[i]->color; info[i].color_index = led->channels[i]->color;
info[i].intensity = 0; info[i].intensity = 0;
...@@ -1600,7 +1597,6 @@ static int lpg_init_sdam(struct lpg *lpg) ...@@ -1600,7 +1597,6 @@ static int lpg_init_sdam(struct lpg *lpg)
static int lpg_probe(struct platform_device *pdev) static int lpg_probe(struct platform_device *pdev)
{ {
struct device_node *np;
struct lpg *lpg; struct lpg *lpg;
int ret; int ret;
int i; int i;
...@@ -1640,12 +1636,10 @@ static int lpg_probe(struct platform_device *pdev) ...@@ -1640,12 +1636,10 @@ static int lpg_probe(struct platform_device *pdev)
if (ret < 0) if (ret < 0)
return ret; return ret;
for_each_available_child_of_node(pdev->dev.of_node, np) { for_each_available_child_of_node_scoped(pdev->dev.of_node, np) {
ret = lpg_add_led(lpg, np); ret = lpg_add_led(lpg, np);
if (ret) { if (ret)
of_node_put(np);
return ret; return ret;
}
} }
for (i = 0; i < lpg->num_channels; i++) for (i = 0; i < lpg->num_channels; i++)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment