Commit 979d5447 authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Jens Axboe

null_blk: cleanup null_gendisk_register

Use a saner size calculation, and do a trivial cleanup on the zone
revalidation to prepare to future changes.
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 5c4bd1f4
...@@ -1559,14 +1559,14 @@ static int init_driver_queues(struct nullb *nullb) ...@@ -1559,14 +1559,14 @@ static int init_driver_queues(struct nullb *nullb)
static int null_gendisk_register(struct nullb *nullb) static int null_gendisk_register(struct nullb *nullb)
{ {
sector_t size = ((sector_t)nullb->dev->size * SZ_1M) >> SECTOR_SHIFT;
struct gendisk *disk; struct gendisk *disk;
sector_t size; int ret;
disk = nullb->disk = alloc_disk_node(1, nullb->dev->home_node); disk = nullb->disk = alloc_disk_node(1, nullb->dev->home_node);
if (!disk) if (!disk)
return -ENOMEM; return -ENOMEM;
size = (sector_t)nullb->dev->size * 1024 * 1024ULL; set_capacity(disk, size);
set_capacity(disk, size >> 9);
disk->flags |= GENHD_FL_EXT_DEVT | GENHD_FL_SUPPRESS_PARTITION_INFO; disk->flags |= GENHD_FL_EXT_DEVT | GENHD_FL_SUPPRESS_PARTITION_INFO;
disk->major = null_major; disk->major = null_major;
...@@ -1577,9 +1577,8 @@ static int null_gendisk_register(struct nullb *nullb) ...@@ -1577,9 +1577,8 @@ static int null_gendisk_register(struct nullb *nullb)
strncpy(disk->disk_name, nullb->disk_name, DISK_NAME_LEN); strncpy(disk->disk_name, nullb->disk_name, DISK_NAME_LEN);
if (nullb->dev->zoned) { if (nullb->dev->zoned) {
int ret = blk_revalidate_disk_zones(disk); ret = blk_revalidate_disk_zones(disk);
if (ret)
if (ret != 0)
return ret; return ret;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment