Commit 9828e6e6 authored by David S. Miller's avatar David S. Miller

rose: Fix signedness issues wrt. digi count.

Just use explicit casts, since we really can't change the
types of structures exported to userspace which have been
around for 15 years or so.
Reported-by: default avatarDan Rosenberg <dan.j.rosenberg@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 3779298b
...@@ -679,7 +679,7 @@ static int rose_bind(struct socket *sock, struct sockaddr *uaddr, int addr_len) ...@@ -679,7 +679,7 @@ static int rose_bind(struct socket *sock, struct sockaddr *uaddr, int addr_len)
if (addr_len == sizeof(struct sockaddr_rose) && addr->srose_ndigis > 1) if (addr_len == sizeof(struct sockaddr_rose) && addr->srose_ndigis > 1)
return -EINVAL; return -EINVAL;
if (addr->srose_ndigis > ROSE_MAX_DIGIS) if ((unsigned int) addr->srose_ndigis > ROSE_MAX_DIGIS)
return -EINVAL; return -EINVAL;
if ((dev = rose_dev_get(&addr->srose_addr)) == NULL) { if ((dev = rose_dev_get(&addr->srose_addr)) == NULL) {
...@@ -739,7 +739,7 @@ static int rose_connect(struct socket *sock, struct sockaddr *uaddr, int addr_le ...@@ -739,7 +739,7 @@ static int rose_connect(struct socket *sock, struct sockaddr *uaddr, int addr_le
if (addr_len == sizeof(struct sockaddr_rose) && addr->srose_ndigis > 1) if (addr_len == sizeof(struct sockaddr_rose) && addr->srose_ndigis > 1)
return -EINVAL; return -EINVAL;
if (addr->srose_ndigis > ROSE_MAX_DIGIS) if ((unsigned int) addr->srose_ndigis > ROSE_MAX_DIGIS)
return -EINVAL; return -EINVAL;
/* Source + Destination digis should not exceed ROSE_MAX_DIGIS */ /* Source + Destination digis should not exceed ROSE_MAX_DIGIS */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment