Commit 9924d852 authored by Laurent Dufour's avatar Laurent Dufour Committed by Luis Henriques

powerpc/xmon: Fix another endiannes issue in RTAS call from xmon

commit e6eb2eba upstream.

The commit 3b8a3c01 ("powerpc/pseries: Fix endiannes issue in RTAS
call from xmon") was fixing an endianness issue in the call made from
xmon to RTAS.

However, as Michael Ellerman noticed, this fix was not complete, the
token value was not byte swapped. This lead to call an unexpected and
most of the time unexisting RTAS function, which is silently ignored by
RTAS.

This fix addresses this hole.
Reported-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
Signed-off-by: default avatarLaurent Dufour <ldufour@linux.vnet.ibm.com>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
Signed-off-by: default avatarLuis Henriques <luis.henriques@canonical.com>
parent fba67b1d
...@@ -292,6 +292,7 @@ static inline void disable_surveillance(void) ...@@ -292,6 +292,7 @@ static inline void disable_surveillance(void)
args.token = rtas_token("set-indicator"); args.token = rtas_token("set-indicator");
if (args.token == RTAS_UNKNOWN_SERVICE) if (args.token == RTAS_UNKNOWN_SERVICE)
return; return;
args.token = cpu_to_be32(args.token);
args.nargs = cpu_to_be32(3); args.nargs = cpu_to_be32(3);
args.nret = cpu_to_be32(1); args.nret = cpu_to_be32(1);
args.rets = &args.args[3]; args.rets = &args.args[3];
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment