Commit 9a54cf46 authored by Masaki Ota's avatar Masaki Ota Committed by Jiri Kosina

HID: alps: fix multitouch cursor issue

Issue reproduction procedure:

1. three or more fingers put on Touchpad.
2. release fingers from Touchpad.
3. move the cursor by one finger.
4. the cursor does not move.

Cause:

We do not notify multi fingers state correctly to input subsystem.  For
example, when three fingers release from Touchpad, fingers state is 3 -> 0. It
needs to notify first, second and third finger's releasing state.

Fix this by not breaking out on z axis and move x,y,z input handling
code to the correct place so that it's in fact per-finger.

[jkosina@suse.cz: reword changelog]
Signed-off-by: default avatarMasaki Ota <masaki.ota@jp.alps.com>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent 884316de
...@@ -190,16 +190,16 @@ static int alps_raw_event(struct hid_device *hdev, ...@@ -190,16 +190,16 @@ static int alps_raw_event(struct hid_device *hdev,
if (z != 0) { if (z != 0) {
input_mt_report_slot_state(hdata->input, input_mt_report_slot_state(hdata->input,
MT_TOOL_FINGER, 1); MT_TOOL_FINGER, 1);
input_report_abs(hdata->input,
ABS_MT_POSITION_X, x);
input_report_abs(hdata->input,
ABS_MT_POSITION_Y, y);
input_report_abs(hdata->input,
ABS_MT_PRESSURE, z);
} else { } else {
input_mt_report_slot_state(hdata->input, input_mt_report_slot_state(hdata->input,
MT_TOOL_FINGER, 0); MT_TOOL_FINGER, 0);
break;
} }
input_report_abs(hdata->input, ABS_MT_POSITION_X, x);
input_report_abs(hdata->input, ABS_MT_POSITION_Y, y);
input_report_abs(hdata->input, ABS_MT_PRESSURE, z);
} }
input_mt_sync_frame(hdata->input); input_mt_sync_frame(hdata->input);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment