Commit 9a6b2a87 authored by Hans Verkuil's avatar Hans Verkuil Committed by Mauro Carvalho Chehab

media: cec: rename pin events/function

The CEC_EVENT_PIN_LOW/HIGH defines and the cec_queue_pin_event() function
did not specify that these were about CEC pin events.

Since in the future there will also be HPD pin events it is wise to rename
the event defines and function to CEC_EVENT_PIN_CEC_LOW/HIGH and
cec_queue_pin_cec_event() now before these become part of the ABI.
Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
parent 583352be
...@@ -127,7 +127,7 @@ returns the information to the application. The ioctl never fails. ...@@ -127,7 +127,7 @@ returns the information to the application. The ioctl never fails.
- 0x00000080 - 0x00000080
- The CEC hardware can monitor CEC pin changes from low to high voltage - The CEC hardware can monitor CEC pin changes from low to high voltage
and vice versa. When in pin monitoring mode the application will and vice versa. When in pin monitoring mode the application will
receive ``CEC_EVENT_PIN_LOW`` and ``CEC_EVENT_PIN_HIGH`` events. receive ``CEC_EVENT_PIN_CEC_LOW`` and ``CEC_EVENT_PIN_CEC_HIGH`` events.
......
...@@ -146,16 +146,16 @@ it is guaranteed that the state did change in between the two events. ...@@ -146,16 +146,16 @@ it is guaranteed that the state did change in between the two events.
- 2 - 2
- Generated if one or more CEC messages were lost because the - Generated if one or more CEC messages were lost because the
application didn't dequeue CEC messages fast enough. application didn't dequeue CEC messages fast enough.
* .. _`CEC-EVENT-PIN-LOW`: * .. _`CEC-EVENT-PIN-CEC-LOW`:
- ``CEC_EVENT_PIN_LOW`` - ``CEC_EVENT_PIN_CEC_LOW``
- 3 - 3
- Generated if the CEC pin goes from a high voltage to a low voltage. - Generated if the CEC pin goes from a high voltage to a low voltage.
Only applies to adapters that have the ``CEC_CAP_MONITOR_PIN`` Only applies to adapters that have the ``CEC_CAP_MONITOR_PIN``
capability set. capability set.
* .. _`CEC-EVENT-PIN-HIGH`: * .. _`CEC-EVENT-PIN-CEC-HIGH`:
- ``CEC_EVENT_PIN_HIGH`` - ``CEC_EVENT_PIN_CEC_HIGH``
- 4 - 4
- Generated if the CEC pin goes from a low voltage to a high voltage. - Generated if the CEC pin goes from a low voltage to a high voltage.
Only applies to adapters that have the ``CEC_CAP_MONITOR_PIN`` Only applies to adapters that have the ``CEC_CAP_MONITOR_PIN``
......
...@@ -159,7 +159,7 @@ Available follower modes are: ...@@ -159,7 +159,7 @@ Available follower modes are:
This mode requires that the :ref:`CEC_CAP_MONITOR_PIN <CEC-CAP-MONITOR-PIN>` This mode requires that the :ref:`CEC_CAP_MONITOR_PIN <CEC-CAP-MONITOR-PIN>`
capability is set, otherwise the ``EINVAL`` error code is returned. capability is set, otherwise the ``EINVAL`` error code is returned.
While in pin monitoring mode this file descriptor can receive the While in pin monitoring mode this file descriptor can receive the
``CEC_EVENT_PIN_LOW`` and ``CEC_EVENT_PIN_HIGH`` events to see the ``CEC_EVENT_PIN_CEC_LOW`` and ``CEC_EVENT_PIN_CEC_HIGH`` events to see the
low-level CEC pin transitions. This is very useful for debugging. low-level CEC pin transitions. This is very useful for debugging.
This mode is only allowed if the process has the ``CAP_NET_ADMIN`` This mode is only allowed if the process has the ``CAP_NET_ADMIN``
capability. If that is not set, then the ``EPERM`` error code is returned. capability. If that is not set, then the ``EPERM`` error code is returned.
......
...@@ -154,10 +154,11 @@ static void cec_queue_event(struct cec_adapter *adap, ...@@ -154,10 +154,11 @@ static void cec_queue_event(struct cec_adapter *adap,
} }
/* Notify userspace that the CEC pin changed state at the given time. */ /* Notify userspace that the CEC pin changed state at the given time. */
void cec_queue_pin_event(struct cec_adapter *adap, bool is_high, ktime_t ts) void cec_queue_pin_cec_event(struct cec_adapter *adap, bool is_high, ktime_t ts)
{ {
struct cec_event ev = { struct cec_event ev = {
.event = is_high ? CEC_EVENT_PIN_HIGH : CEC_EVENT_PIN_LOW, .event = is_high ? CEC_EVENT_PIN_CEC_HIGH :
CEC_EVENT_PIN_CEC_LOW,
}; };
struct cec_fh *fh; struct cec_fh *fh;
...@@ -167,7 +168,7 @@ void cec_queue_pin_event(struct cec_adapter *adap, bool is_high, ktime_t ts) ...@@ -167,7 +168,7 @@ void cec_queue_pin_event(struct cec_adapter *adap, bool is_high, ktime_t ts)
cec_queue_event_fh(fh, &ev, ktime_to_ns(ts)); cec_queue_event_fh(fh, &ev, ktime_to_ns(ts));
mutex_unlock(&adap->devnode.lock); mutex_unlock(&adap->devnode.lock);
} }
EXPORT_SYMBOL_GPL(cec_queue_pin_event); EXPORT_SYMBOL_GPL(cec_queue_pin_cec_event);
/* /*
* Queue a new message for this filehandle. * Queue a new message for this filehandle.
......
...@@ -449,8 +449,8 @@ static long cec_s_mode(struct cec_adapter *adap, struct cec_fh *fh, ...@@ -449,8 +449,8 @@ static long cec_s_mode(struct cec_adapter *adap, struct cec_fh *fh,
.flags = CEC_EVENT_FL_INITIAL_STATE, .flags = CEC_EVENT_FL_INITIAL_STATE,
}; };
ev.event = adap->pin->cur_value ? CEC_EVENT_PIN_HIGH : ev.event = adap->pin->cur_value ? CEC_EVENT_PIN_CEC_HIGH :
CEC_EVENT_PIN_LOW; CEC_EVENT_PIN_CEC_LOW;
cec_queue_event_fh(fh, &ev, 0); cec_queue_event_fh(fh, &ev, 0);
#endif #endif
adap->monitor_pin_cnt++; adap->monitor_pin_cnt++;
......
...@@ -609,8 +609,9 @@ static int cec_pin_thread_func(void *_adap) ...@@ -609,8 +609,9 @@ static int cec_pin_thread_func(void *_adap)
while (atomic_read(&pin->work_pin_events)) { while (atomic_read(&pin->work_pin_events)) {
unsigned int idx = pin->work_pin_events_rd; unsigned int idx = pin->work_pin_events_rd;
cec_queue_pin_event(adap, pin->work_pin_is_high[idx], cec_queue_pin_cec_event(adap,
pin->work_pin_ts[idx]); pin->work_pin_is_high[idx],
pin->work_pin_ts[idx]);
pin->work_pin_events_rd = (idx + 1) % CEC_NUM_PIN_EVENTS; pin->work_pin_events_rd = (idx + 1) % CEC_NUM_PIN_EVENTS;
atomic_dec(&pin->work_pin_events); atomic_dec(&pin->work_pin_events);
} }
......
...@@ -91,7 +91,7 @@ struct cec_event_entry { ...@@ -91,7 +91,7 @@ struct cec_event_entry {
}; };
#define CEC_NUM_CORE_EVENTS 2 #define CEC_NUM_CORE_EVENTS 2
#define CEC_NUM_EVENTS CEC_EVENT_PIN_HIGH #define CEC_NUM_EVENTS CEC_EVENT_PIN_CEC_HIGH
struct cec_fh { struct cec_fh {
struct list_head list; struct list_head list;
...@@ -280,14 +280,15 @@ static inline void cec_received_msg(struct cec_adapter *adap, ...@@ -280,14 +280,15 @@ static inline void cec_received_msg(struct cec_adapter *adap,
} }
/** /**
* cec_queue_pin_event() - queue a pin event with a given timestamp. * cec_queue_pin_cec_event() - queue a CEC pin event with a given timestamp.
* *
* @adap: pointer to the cec adapter * @adap: pointer to the cec adapter
* @is_high: when true the pin is high, otherwise it is low * @is_high: when true the CEC pin is high, otherwise it is low
* @ts: the timestamp for this event * @ts: the timestamp for this event
* *
*/ */
void cec_queue_pin_event(struct cec_adapter *adap, bool is_high, ktime_t ts); void cec_queue_pin_cec_event(struct cec_adapter *adap,
bool is_high, ktime_t ts);
/** /**
* cec_get_edid_phys_addr() - find and return the physical address * cec_get_edid_phys_addr() - find and return the physical address
......
...@@ -408,8 +408,8 @@ struct cec_log_addrs { ...@@ -408,8 +408,8 @@ struct cec_log_addrs {
* didn't empty the message queue in time * didn't empty the message queue in time
*/ */
#define CEC_EVENT_LOST_MSGS 2 #define CEC_EVENT_LOST_MSGS 2
#define CEC_EVENT_PIN_LOW 3 #define CEC_EVENT_PIN_CEC_LOW 3
#define CEC_EVENT_PIN_HIGH 4 #define CEC_EVENT_PIN_CEC_HIGH 4
#define CEC_EVENT_FL_INITIAL_STATE (1 << 0) #define CEC_EVENT_FL_INITIAL_STATE (1 << 0)
#define CEC_EVENT_FL_DROPPED_EVENTS (1 << 1) #define CEC_EVENT_FL_DROPPED_EVENTS (1 << 1)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment