Commit 9bcc07f0 authored by Lihong Yang's avatar Lihong Yang Committed by Jeff Kirsher

i40e: use a local variable instead of calculating multiple times

The computed result of I40E_MAX_VSI_QP * I40E_VIRTCHNL_SUPPORTED_QTYPES
is used more than three times in function i40e_config_irq_link_list.
Simply declare a local variable to store it to improve readability.
Signed-off-by: default avatarLihong Yang <lihong.yang@intel.com>
Tested-by: default avatarAndrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent 4988410f
...@@ -273,7 +273,7 @@ static void i40e_config_irq_link_list(struct i40e_vf *vf, u16 vsi_id, ...@@ -273,7 +273,7 @@ static void i40e_config_irq_link_list(struct i40e_vf *vf, u16 vsi_id,
struct i40e_hw *hw = &pf->hw; struct i40e_hw *hw = &pf->hw;
u16 vsi_queue_id, pf_queue_id; u16 vsi_queue_id, pf_queue_id;
enum i40e_queue_type qtype; enum i40e_queue_type qtype;
u16 next_q, vector_id; u16 next_q, vector_id, size;
u32 reg, reg_idx; u32 reg, reg_idx;
u16 itr_idx = 0; u16 itr_idx = 0;
...@@ -303,11 +303,9 @@ static void i40e_config_irq_link_list(struct i40e_vf *vf, u16 vsi_id, ...@@ -303,11 +303,9 @@ static void i40e_config_irq_link_list(struct i40e_vf *vf, u16 vsi_id,
vsi_queue_id + 1)); vsi_queue_id + 1));
} }
next_q = find_first_bit(&linklistmap, size = I40E_MAX_VSI_QP * I40E_VIRTCHNL_SUPPORTED_QTYPES;
(I40E_MAX_VSI_QP * next_q = find_first_bit(&linklistmap, size);
I40E_VIRTCHNL_SUPPORTED_QTYPES)); if (unlikely(next_q == size))
if (unlikely(next_q == (I40E_MAX_VSI_QP *
I40E_VIRTCHNL_SUPPORTED_QTYPES)))
goto irq_list_done; goto irq_list_done;
vsi_queue_id = next_q / I40E_VIRTCHNL_SUPPORTED_QTYPES; vsi_queue_id = next_q / I40E_VIRTCHNL_SUPPORTED_QTYPES;
...@@ -317,7 +315,7 @@ static void i40e_config_irq_link_list(struct i40e_vf *vf, u16 vsi_id, ...@@ -317,7 +315,7 @@ static void i40e_config_irq_link_list(struct i40e_vf *vf, u16 vsi_id,
wr32(hw, reg_idx, reg); wr32(hw, reg_idx, reg);
while (next_q < (I40E_MAX_VSI_QP * I40E_VIRTCHNL_SUPPORTED_QTYPES)) { while (next_q < size) {
switch (qtype) { switch (qtype) {
case I40E_QUEUE_TYPE_RX: case I40E_QUEUE_TYPE_RX:
reg_idx = I40E_QINT_RQCTL(pf_queue_id); reg_idx = I40E_QINT_RQCTL(pf_queue_id);
...@@ -331,12 +329,8 @@ static void i40e_config_irq_link_list(struct i40e_vf *vf, u16 vsi_id, ...@@ -331,12 +329,8 @@ static void i40e_config_irq_link_list(struct i40e_vf *vf, u16 vsi_id,
break; break;
} }
next_q = find_next_bit(&linklistmap, next_q = find_next_bit(&linklistmap, size, next_q + 1);
(I40E_MAX_VSI_QP * if (next_q < size) {
I40E_VIRTCHNL_SUPPORTED_QTYPES),
next_q + 1);
if (next_q <
(I40E_MAX_VSI_QP * I40E_VIRTCHNL_SUPPORTED_QTYPES)) {
vsi_queue_id = next_q / I40E_VIRTCHNL_SUPPORTED_QTYPES; vsi_queue_id = next_q / I40E_VIRTCHNL_SUPPORTED_QTYPES;
qtype = next_q % I40E_VIRTCHNL_SUPPORTED_QTYPES; qtype = next_q % I40E_VIRTCHNL_SUPPORTED_QTYPES;
pf_queue_id = i40e_vc_get_pf_queue_id(vf, vsi_id, pf_queue_id = i40e_vc_get_pf_queue_id(vf, vsi_id,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment