Commit 9f4651ea authored by Jacob Keller's avatar Jacob Keller Committed by Tony Nguyen

iavf: return errno code instead of status code

The iavf_parse_cls_flower function returns an integer error code, and
not an iavf_status enumeration.

Fix the function to use the standard errno value EINVAL as its return
instead of using IAVF_ERR_CONFIG.
Signed-off-by: default avatarJacob Keller <jacob.e.keller@intel.com>
Tested-by: default avatarKonrad Jankowski <konrad0.jankowski@intel.com>
Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
parent f1db020b
...@@ -2910,7 +2910,7 @@ static int iavf_parse_cls_flower(struct iavf_adapter *adapter, ...@@ -2910,7 +2910,7 @@ static int iavf_parse_cls_flower(struct iavf_adapter *adapter,
} else { } else {
dev_err(&adapter->pdev->dev, "Bad ether dest mask %pM\n", dev_err(&adapter->pdev->dev, "Bad ether dest mask %pM\n",
match.mask->dst); match.mask->dst);
return IAVF_ERR_CONFIG; return -EINVAL;
} }
} }
...@@ -2920,7 +2920,7 @@ static int iavf_parse_cls_flower(struct iavf_adapter *adapter, ...@@ -2920,7 +2920,7 @@ static int iavf_parse_cls_flower(struct iavf_adapter *adapter,
} else { } else {
dev_err(&adapter->pdev->dev, "Bad ether src mask %pM\n", dev_err(&adapter->pdev->dev, "Bad ether src mask %pM\n",
match.mask->src); match.mask->src);
return IAVF_ERR_CONFIG; return -EINVAL;
} }
} }
...@@ -2955,7 +2955,7 @@ static int iavf_parse_cls_flower(struct iavf_adapter *adapter, ...@@ -2955,7 +2955,7 @@ static int iavf_parse_cls_flower(struct iavf_adapter *adapter,
} else { } else {
dev_err(&adapter->pdev->dev, "Bad vlan mask %u\n", dev_err(&adapter->pdev->dev, "Bad vlan mask %u\n",
match.mask->vlan_id); match.mask->vlan_id);
return IAVF_ERR_CONFIG; return -EINVAL;
} }
} }
vf->mask.tcp_spec.vlan_id |= cpu_to_be16(0xffff); vf->mask.tcp_spec.vlan_id |= cpu_to_be16(0xffff);
...@@ -2979,7 +2979,7 @@ static int iavf_parse_cls_flower(struct iavf_adapter *adapter, ...@@ -2979,7 +2979,7 @@ static int iavf_parse_cls_flower(struct iavf_adapter *adapter,
} else { } else {
dev_err(&adapter->pdev->dev, "Bad ip dst mask 0x%08x\n", dev_err(&adapter->pdev->dev, "Bad ip dst mask 0x%08x\n",
be32_to_cpu(match.mask->dst)); be32_to_cpu(match.mask->dst));
return IAVF_ERR_CONFIG; return -EINVAL;
} }
} }
...@@ -2989,13 +2989,13 @@ static int iavf_parse_cls_flower(struct iavf_adapter *adapter, ...@@ -2989,13 +2989,13 @@ static int iavf_parse_cls_flower(struct iavf_adapter *adapter,
} else { } else {
dev_err(&adapter->pdev->dev, "Bad ip src mask 0x%08x\n", dev_err(&adapter->pdev->dev, "Bad ip src mask 0x%08x\n",
be32_to_cpu(match.mask->dst)); be32_to_cpu(match.mask->dst));
return IAVF_ERR_CONFIG; return -EINVAL;
} }
} }
if (field_flags & IAVF_CLOUD_FIELD_TEN_ID) { if (field_flags & IAVF_CLOUD_FIELD_TEN_ID) {
dev_info(&adapter->pdev->dev, "Tenant id not allowed for ip filter\n"); dev_info(&adapter->pdev->dev, "Tenant id not allowed for ip filter\n");
return IAVF_ERR_CONFIG; return -EINVAL;
} }
if (match.key->dst) { if (match.key->dst) {
vf->mask.tcp_spec.dst_ip[0] |= cpu_to_be32(0xffffffff); vf->mask.tcp_spec.dst_ip[0] |= cpu_to_be32(0xffffffff);
...@@ -3016,7 +3016,7 @@ static int iavf_parse_cls_flower(struct iavf_adapter *adapter, ...@@ -3016,7 +3016,7 @@ static int iavf_parse_cls_flower(struct iavf_adapter *adapter,
if (ipv6_addr_any(&match.mask->dst)) { if (ipv6_addr_any(&match.mask->dst)) {
dev_err(&adapter->pdev->dev, "Bad ipv6 dst mask 0x%02x\n", dev_err(&adapter->pdev->dev, "Bad ipv6 dst mask 0x%02x\n",
IPV6_ADDR_ANY); IPV6_ADDR_ANY);
return IAVF_ERR_CONFIG; return -EINVAL;
} }
/* src and dest IPv6 address should not be LOOPBACK /* src and dest IPv6 address should not be LOOPBACK
...@@ -3026,7 +3026,7 @@ static int iavf_parse_cls_flower(struct iavf_adapter *adapter, ...@@ -3026,7 +3026,7 @@ static int iavf_parse_cls_flower(struct iavf_adapter *adapter,
ipv6_addr_loopback(&match.key->src)) { ipv6_addr_loopback(&match.key->src)) {
dev_err(&adapter->pdev->dev, dev_err(&adapter->pdev->dev,
"ipv6 addr should not be loopback\n"); "ipv6 addr should not be loopback\n");
return IAVF_ERR_CONFIG; return -EINVAL;
} }
if (!ipv6_addr_any(&match.mask->dst) || if (!ipv6_addr_any(&match.mask->dst) ||
!ipv6_addr_any(&match.mask->src)) !ipv6_addr_any(&match.mask->src))
...@@ -3051,7 +3051,7 @@ static int iavf_parse_cls_flower(struct iavf_adapter *adapter, ...@@ -3051,7 +3051,7 @@ static int iavf_parse_cls_flower(struct iavf_adapter *adapter,
} else { } else {
dev_err(&adapter->pdev->dev, "Bad src port mask %u\n", dev_err(&adapter->pdev->dev, "Bad src port mask %u\n",
be16_to_cpu(match.mask->src)); be16_to_cpu(match.mask->src));
return IAVF_ERR_CONFIG; return -EINVAL;
} }
} }
...@@ -3061,7 +3061,7 @@ static int iavf_parse_cls_flower(struct iavf_adapter *adapter, ...@@ -3061,7 +3061,7 @@ static int iavf_parse_cls_flower(struct iavf_adapter *adapter,
} else { } else {
dev_err(&adapter->pdev->dev, "Bad dst port mask %u\n", dev_err(&adapter->pdev->dev, "Bad dst port mask %u\n",
be16_to_cpu(match.mask->dst)); be16_to_cpu(match.mask->dst));
return IAVF_ERR_CONFIG; return -EINVAL;
} }
} }
if (match.key->dst) { if (match.key->dst) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment