Commit a0b84213 authored by Richard Fitzgerald's avatar Richard Fitzgerald Committed by Shuah Khan

kunit: Fix NULL-dereference in kunit_init_suite() if suite->log is NULL

suite->log must be checked for NULL before passing it to
string_stream_clear(). This was done in kunit_init_test() but was missing
from kunit_init_suite().
Signed-off-by: default avatarRichard Fitzgerald <rf@opensource.cirrus.com>
Fixes: 6d696c4695c5 ("kunit: add ability to run tests after boot using debugfs")
Reviewed-by: default avatarRae Moar <rmoar@google.com>
Acked-by: default avatarDavid Gow <davidgow@google.com>
Reviewed-by: default avatarMuhammad Usama Anjum <usama.anjum@collabora.com>
Signed-off-by: default avatarShuah Khan <skhan@linuxfoundation.org>
parent 342fb978
...@@ -697,7 +697,9 @@ static void kunit_init_suite(struct kunit_suite *suite) ...@@ -697,7 +697,9 @@ static void kunit_init_suite(struct kunit_suite *suite)
kunit_debugfs_create_suite(suite); kunit_debugfs_create_suite(suite);
suite->status_comment[0] = '\0'; suite->status_comment[0] = '\0';
suite->suite_init_err = 0; suite->suite_init_err = 0;
string_stream_clear(suite->log);
if (suite->log)
string_stream_clear(suite->log);
} }
bool kunit_enabled(void) bool kunit_enabled(void)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment