Commit a186762b authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Mark Brown

ASoC: atmel: sam9g20_wm8731: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: default avatarClaudiu Beznea <claudiu.beznea@microchip.com>
Acked-by: default avatarTakashi Iwai <tiwai@suse.de>
Acked-by: default avatarNicolas Ferre <nicolas.ferre@microchip.com>
Link: https://lore.kernel.org/r/20230315150745.67084-32-u.kleine-koenig@pengutronix.deSigned-off-by: default avatarMark Brown <broonie@kernel.org>
parent 2328c487
...@@ -186,14 +186,12 @@ static int at91sam9g20ek_audio_probe(struct platform_device *pdev) ...@@ -186,14 +186,12 @@ static int at91sam9g20ek_audio_probe(struct platform_device *pdev)
return ret; return ret;
} }
static int at91sam9g20ek_audio_remove(struct platform_device *pdev) static void at91sam9g20ek_audio_remove(struct platform_device *pdev)
{ {
struct snd_soc_card *card = platform_get_drvdata(pdev); struct snd_soc_card *card = platform_get_drvdata(pdev);
snd_soc_unregister_card(card); snd_soc_unregister_card(card);
atmel_ssc_put_audio(0); atmel_ssc_put_audio(0);
return 0;
} }
#ifdef CONFIG_OF #ifdef CONFIG_OF
...@@ -210,7 +208,7 @@ static struct platform_driver at91sam9g20ek_audio_driver = { ...@@ -210,7 +208,7 @@ static struct platform_driver at91sam9g20ek_audio_driver = {
.of_match_table = of_match_ptr(at91sam9g20ek_wm8731_dt_ids), .of_match_table = of_match_ptr(at91sam9g20ek_wm8731_dt_ids),
}, },
.probe = at91sam9g20ek_audio_probe, .probe = at91sam9g20ek_audio_probe,
.remove = at91sam9g20ek_audio_remove, .remove_new = at91sam9g20ek_audio_remove,
}; };
module_platform_driver(at91sam9g20ek_audio_driver); module_platform_driver(at91sam9g20ek_audio_driver);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment