Commit a34ae6c0 authored by Takashi Iwai's avatar Takashi Iwai

ALSA: wavefront: Proper check of get_user() error

The antient ISA wavefront driver reads its sample patch data (uploaded
over an ioctl) via __get_user() with no good reason; likely just for
some performance optimizations in the past.  Let's change this to the
standard get_user() and the error check for handling the fault case
properly.
Reported-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20220510103626.16635-1-tiwai@suse.deSigned-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 1efcdd9c
...@@ -1094,7 +1094,8 @@ wavefront_send_sample (snd_wavefront_t *dev, ...@@ -1094,7 +1094,8 @@ wavefront_send_sample (snd_wavefront_t *dev,
if (dataptr < data_end) { if (dataptr < data_end) {
__get_user (sample_short, dataptr); if (get_user(sample_short, dataptr))
return -EFAULT;
dataptr += skip; dataptr += skip;
if (data_is_unsigned) { /* GUS ? */ if (data_is_unsigned) { /* GUS ? */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment