Commit a4ef829c authored by James Morris's avatar James Morris

[CRYPTO]: minor updates

- Fixed min keysize bug for Blowfish (it is 32, not 64).
- Documentation updates.
parent 74bfd9f5
...@@ -105,6 +105,10 @@ Also check for any RFCs which may relate to the use of specific algorithms, ...@@ -105,6 +105,10 @@ Also check for any RFCs which may relate to the use of specific algorithms,
as well as general application notes such as RFC2451 ("The ESP CBC-Mode as well as general application notes such as RFC2451 ("The ESP CBC-Mode
Cipher Algorithms"). Cipher Algorithms").
It's a good idea to avoid using lots of macros and use inlined functions
instead, as gcc does a good job with inlining, while excessive use of
macros can cause compilation problems on some platforms.
BUGS BUGS
...@@ -167,7 +171,7 @@ Original developers of the initial set of crypto algorithms: ...@@ -167,7 +171,7 @@ Original developers of the initial set of crypto algorithms:
Dana L. How (DES) Dana L. How (DES)
Andrew Tridgell and Steve French (MD4) Andrew Tridgell and Steve French (MD4)
Colin Plumb (MD5) Colin Plumb (MD5)
Steve Raid (SHA1) Steve Reid (SHA1)
Jean-Luc Cooke (SHA256) Jean-Luc Cooke (SHA256)
Kazunori Miyazawa / USAGI (HMAC) Kazunori Miyazawa / USAGI (HMAC)
......
...@@ -55,9 +55,9 @@ config CRYPTO_BLOWFISH ...@@ -55,9 +55,9 @@ config CRYPTO_BLOWFISH
help help
Blowfish cipher algorithm, by Bruce Schneier. Blowfish cipher algorithm, by Bruce Schneier.
This is a fast cipher which can use variable length key from 32 This is a variable key length cipher which can use keys from 32
bits to 448 bits. It's fast, simple and specifically designed for bits to 448 bits in length. It's fast, simple and specifically
use on "large microprocessors". designed for use on "large microprocessors".
See also: See also:
http://www.counterpane.com/blowfish.html http://www.counterpane.com/blowfish.html
......
...@@ -23,7 +23,7 @@ ...@@ -23,7 +23,7 @@
#include <linux/crypto.h> #include <linux/crypto.h>
#define BF_BLOCK_SIZE 8 #define BF_BLOCK_SIZE 8
#define BF_MIN_KEY_SIZE 8 #define BF_MIN_KEY_SIZE 4
#define BF_MAX_KEY_SIZE 56 #define BF_MAX_KEY_SIZE 56
struct bf_ctx { struct bf_ctx {
......
...@@ -5,7 +5,7 @@ ...@@ -5,7 +5,7 @@
* *
* Derived from cryptoapi implementation, adapted for in-place * Derived from cryptoapi implementation, adapted for in-place
* scatterlist interface. Originally based on the public domain * scatterlist interface. Originally based on the public domain
* implementation written by Steve Raid. * implementation written by Steve Reid.
* *
* Copyright (c) Alan Smithee. * Copyright (c) Alan Smithee.
* Copyright (c) Andrew McDonald <andrew@mcdonald.org.uk> * Copyright (c) Andrew McDonald <andrew@mcdonald.org.uk>
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment