Commit a5a2a0c7 authored by Darren Hart's avatar Darren Hart Committed by Thomas Gleixner

futex: fix futex_wait_setup key handling

If the get_futex_key() call were to fail, the existing code would
try and put_futex_key() prior to returning.  This patch makes sure
we only put_futex_key() if get_futex_key() succeeded.
Reported-by: default avatarClark Williams <williams@redhat.com>
Signed-off-by: default avatarDarren Hart <dvhltc@us.ibm.com>
LKML-Reference: <20090410165005.14342.16973.stgit@Aeon>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
parent d2de6888
......@@ -1668,7 +1668,7 @@ static int futex_wait_setup(u32 __user *uaddr, u32 val, int fshared,
q->key = FUTEX_KEY_INIT;
ret = get_futex_key(uaddr, fshared, &q->key);
if (unlikely(ret != 0))
goto out;
return ret;
retry_private:
*hb = queue_lock(q);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment