Commit a78b32d9 authored by Pierre-Louis Bossart's avatar Pierre-Louis Bossart Committed by Vinod Koul

soundwire: cadence_master: log Slave status mask on errors

The Slave status mask exposes 4 sticky bits. When the device loses
sync, the IP will report two status but the log will only show that
the device lost sync. The status mask has all the information needed
so let's report it instead.

Also change the resolution of the mask, using 64 bits is not needed
when you need 4.
Signed-off-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent eb7df4c8
......@@ -487,7 +487,8 @@ static int cdns_update_slave_status(struct sdw_cdns *cdns,
{
enum sdw_slave_status status[SDW_MAX_DEVICES + 1];
bool is_slave = false;
u64 slave, mask;
u64 slave;
u32 mask;
int i, set_status;
/* combine the two status */
......@@ -527,7 +528,7 @@ static int cdns_update_slave_status(struct sdw_cdns *cdns,
if (set_status > 1) {
dev_warn_ratelimited(cdns->dev,
"Slave reported multiple Status: %d\n",
status[i]);
mask);
/*
* TODO: we need to reread the status here by
* issuing a PING cmd
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment