Commit a8c1dc9e authored by Daniel Mack's avatar Daniel Mack Committed by Mark Brown

ASoC: max98396: Improve some error prints

Let's log what actually failed and log at some more places.
Signed-off-by: default avatarDaniel Mack <daniel@zonque.org>
Link: https://lore.kernel.org/r/20220624104712.1934484-6-daniel@zonque.orgSigned-off-by: default avatarMark Brown <broonie@kernel.org>
parent 703ee055
...@@ -372,7 +372,8 @@ static int max98396_dai_set_fmt(struct snd_soc_dai *codec_dai, unsigned int fmt) ...@@ -372,7 +372,8 @@ static int max98396_dai_set_fmt(struct snd_soc_dai *codec_dai, unsigned int fmt)
break; break;
default: default:
dev_err(component->dev, "DAI invert mode unsupported\n"); dev_err(component->dev, "DAI invert mode %d unsupported\n",
fmt & SND_SOC_DAIFMT_INV_MASK);
return -EINVAL; return -EINVAL;
} }
...@@ -391,6 +392,8 @@ static int max98396_dai_set_fmt(struct snd_soc_dai *codec_dai, unsigned int fmt) ...@@ -391,6 +392,8 @@ static int max98396_dai_set_fmt(struct snd_soc_dai *codec_dai, unsigned int fmt)
format |= MAX98396_PCM_FORMAT_TDM_MODE0; format |= MAX98396_PCM_FORMAT_TDM_MODE0;
break; break;
default: default:
dev_err(component->dev, "DAI format %d unsupported\n",
fmt & SND_SOC_DAIFMT_FORMAT_MASK);
return -EINVAL; return -EINVAL;
} }
...@@ -461,8 +464,9 @@ static int max98396_set_clock(struct snd_soc_component *component, ...@@ -461,8 +464,9 @@ static int max98396_set_clock(struct snd_soc_component *component,
/* BCLK configuration */ /* BCLK configuration */
value = max98396_get_bclk_sel(blr_clk_ratio); value = max98396_get_bclk_sel(blr_clk_ratio);
if (!value) { if (!value) {
dev_err(component->dev, "format unsupported %d\n", dev_err(component->dev,
params_format(params)); "blr_clk_ratio %d unsupported, format %d\n",
blr_clk_ratio, params_format(params));
return -EINVAL; return -EINVAL;
} }
...@@ -647,7 +651,7 @@ static int max98396_dai_tdm_slot(struct snd_soc_dai *dai, ...@@ -647,7 +651,7 @@ static int max98396_dai_tdm_slot(struct snd_soc_dai *dai,
chan_sz = MAX98396_PCM_MODE_CFG_CHANSZ_32; chan_sz = MAX98396_PCM_MODE_CFG_CHANSZ_32;
break; break;
default: default:
dev_err(component->dev, "format unsupported %d\n", dev_err(component->dev, "slot width %d unsupported\n",
slot_width); slot_width);
return -EINVAL; return -EINVAL;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment