Commit a9e9b091 authored by Yang Yingliang's avatar Yang Yingliang Committed by Jakub Kicinski

net: dsa: mt7530: add missing of_node_put() in mt7530_setup()

Add of_node_put() if of_get_phy_mode() fails in mt7530_setup()

Fixes: 0c65b2b9 ("net: of_get_phy_mode: Change API to solve int/unit warnings")
Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20220428095317.538829-1-yangyingliang@huawei.comSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent fee34dd1
...@@ -2229,6 +2229,7 @@ mt7530_setup(struct dsa_switch *ds) ...@@ -2229,6 +2229,7 @@ mt7530_setup(struct dsa_switch *ds)
ret = of_get_phy_mode(mac_np, &interface); ret = of_get_phy_mode(mac_np, &interface);
if (ret && ret != -ENODEV) { if (ret && ret != -ENODEV) {
of_node_put(mac_np); of_node_put(mac_np);
of_node_put(phy_node);
return ret; return ret;
} }
id = of_mdio_parse_addr(ds->dev, phy_node); id = of_mdio_parse_addr(ds->dev, phy_node);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment