Commit ab68d5bb authored by Jani Nikula's avatar Jani Nikula Committed by Daniel Vetter

drm/i915: put back the indent in intel_hpd_irq_handler

In an unfortunate back and forth stepping, retract the earlier change to
reduce indent. This is to make merging the two loops easier. No
functional changes.
Signed-off-by: default avatarJani Nikula <jani.nikula@intel.com>
Reviewed-by: default avatarPaulo Zanoni <paulo.r.zanoni@intel.com>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
parent 641a969e
...@@ -1442,39 +1442,38 @@ static void intel_hpd_irq_handler(struct drm_device *dev, ...@@ -1442,39 +1442,38 @@ static void intel_hpd_irq_handler(struct drm_device *dev,
spin_lock(&dev_priv->irq_lock); spin_lock(&dev_priv->irq_lock);
for_each_hpd_pin(i) { for_each_hpd_pin(i) {
bool long_hpd;
if (!(hpd[i] & hotplug_trigger)) if (!(hpd[i] & hotplug_trigger))
continue; continue;
port = get_port_from_pin(i); port = get_port_from_pin(i);
if (!port || !dev_priv->hotplug.irq_port[port]) if (port && dev_priv->hotplug.irq_port[port]) {
continue; bool long_hpd;
if (!HAS_GMCH_DISPLAY(dev_priv)) { if (!HAS_GMCH_DISPLAY(dev_priv)) {
dig_shift = pch_port_to_hotplug_shift(port); dig_shift = pch_port_to_hotplug_shift(port);
long_hpd = (dig_hotplug_reg >> dig_shift) & PORTB_HOTPLUG_LONG_DETECT; long_hpd = (dig_hotplug_reg >> dig_shift) & PORTB_HOTPLUG_LONG_DETECT;
} else { } else {
dig_shift = i915_port_to_hotplug_shift(port); dig_shift = i915_port_to_hotplug_shift(port);
long_hpd = (hotplug_trigger >> dig_shift) & PORTB_HOTPLUG_LONG_DETECT; long_hpd = (hotplug_trigger >> dig_shift) & PORTB_HOTPLUG_LONG_DETECT;
} }
DRM_DEBUG_DRIVER("digital hpd port %c - %s\n", port_name(port), DRM_DEBUG_DRIVER("digital hpd port %c - %s\n", port_name(port),
long_hpd ? "long" : "short"); long_hpd ? "long" : "short");
/* /*
* For long HPD pulses we want to have the digital queue happen, * For long HPD pulses we want to have the digital queue happen,
* but we still want HPD storm detection to function. * but we still want HPD storm detection to function.
*/ */
if (long_hpd) { if (long_hpd) {
dev_priv->hotplug.long_port_mask |= (1 << port); dev_priv->hotplug.long_port_mask |= (1 << port);
dig_port_mask |= hpd[i]; dig_port_mask |= hpd[i];
} else { } else {
/* for short HPD just trigger the digital queue */ /* for short HPD just trigger the digital queue */
dev_priv->hotplug.short_port_mask |= (1 << port); dev_priv->hotplug.short_port_mask |= (1 << port);
hotplug_trigger &= ~hpd[i]; hotplug_trigger &= ~hpd[i];
} }
queue_dig = true; queue_dig = true;
}
} }
for_each_hpd_pin(i) { for_each_hpd_pin(i) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment