Commit ac6c5e3d authored by Shannon Nelson's avatar Shannon Nelson Committed by Jeff Kirsher

i40e: only set up the rings to be used

The VSI may be allocated more queues (alloc_queue_pairs) than actually
are to be used (num_queue_pairs), so only allocate rings for the queues
to be used.  The numbers will likely be the same for most VSIs, but can
be different based on how TCs are assigned and enabled.

Change-Id: Ie40f7ad0affbc4b45d6f049bcf02ee2fa24edc74
Signed-off-by: default avatarShannon Nelson <shannon.nelson@intel.com>
Signed-off-by: default avatarJesse Brandeburg <jesse.brandeburg@intel.com>
Tested-by: default avatarKavindya Deegala <kavindya.s.deegala@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent 4617e8c0
...@@ -5087,12 +5087,11 @@ static int i40e_vsi_alloc_arrays(struct i40e_vsi *vsi) ...@@ -5087,12 +5087,11 @@ static int i40e_vsi_alloc_arrays(struct i40e_vsi *vsi)
int size; int size;
int ret = 0; int ret = 0;
/* allocate memory for ring pointers */ /* allocate memory for both Tx and Rx ring pointers */
size = sizeof(struct i40e_ring *) * vsi->alloc_queue_pairs * 2; size = sizeof(struct i40e_ring *) * vsi->alloc_queue_pairs * 2;
vsi->tx_rings = kzalloc(size, GFP_KERNEL); vsi->tx_rings = kzalloc(size, GFP_KERNEL);
if (!vsi->tx_rings) if (!vsi->tx_rings)
return -ENOMEM; return -ENOMEM;
vsi->rx_rings = &vsi->tx_rings[vsi->alloc_queue_pairs]; vsi->rx_rings = &vsi->tx_rings[vsi->alloc_queue_pairs];
/* allocate memory for q_vector pointers */ /* allocate memory for q_vector pointers */
...@@ -5265,7 +5264,7 @@ static s32 i40e_vsi_clear_rings(struct i40e_vsi *vsi) ...@@ -5265,7 +5264,7 @@ static s32 i40e_vsi_clear_rings(struct i40e_vsi *vsi)
int i; int i;
if (vsi->tx_rings[0]) if (vsi->tx_rings[0])
for (i = 0; i < vsi->alloc_queue_pairs; i++) { for (i = 0; i < vsi->num_queue_pairs; i++) {
kfree_rcu(vsi->tx_rings[i], rcu); kfree_rcu(vsi->tx_rings[i], rcu);
vsi->tx_rings[i] = NULL; vsi->tx_rings[i] = NULL;
vsi->rx_rings[i] = NULL; vsi->rx_rings[i] = NULL;
...@@ -5284,10 +5283,11 @@ static int i40e_alloc_rings(struct i40e_vsi *vsi) ...@@ -5284,10 +5283,11 @@ static int i40e_alloc_rings(struct i40e_vsi *vsi)
int i; int i;
/* Set basic values in the rings to be used later during open() */ /* Set basic values in the rings to be used later during open() */
for (i = 0; i < vsi->alloc_queue_pairs; i++) { for (i = 0; i < vsi->num_queue_pairs; i++) {
struct i40e_ring *tx_ring; struct i40e_ring *tx_ring;
struct i40e_ring *rx_ring; struct i40e_ring *rx_ring;
/* allocate space for both Tx and Rx in one shot */
tx_ring = kzalloc(sizeof(struct i40e_ring) * 2, GFP_KERNEL); tx_ring = kzalloc(sizeof(struct i40e_ring) * 2, GFP_KERNEL);
if (!tx_ring) if (!tx_ring)
goto err_out; goto err_out;
...@@ -5858,7 +5858,7 @@ static int i40e_config_netdev(struct i40e_vsi *vsi) ...@@ -5858,7 +5858,7 @@ static int i40e_config_netdev(struct i40e_vsi *vsi)
int etherdev_size; int etherdev_size;
etherdev_size = sizeof(struct i40e_netdev_priv); etherdev_size = sizeof(struct i40e_netdev_priv);
netdev = alloc_etherdev_mq(etherdev_size, vsi->alloc_queue_pairs); netdev = alloc_etherdev_mq(etherdev_size, vsi->num_queue_pairs);
if (!netdev) if (!netdev)
return -ENOMEM; return -ENOMEM;
...@@ -6939,8 +6939,8 @@ static int i40e_setup_pf_switch(struct i40e_pf *pf) ...@@ -6939,8 +6939,8 @@ static int i40e_setup_pf_switch(struct i40e_pf *pf)
* into the pf, since this newer code pushes the pf queue * into the pf, since this newer code pushes the pf queue
* info down a level into a VSI * info down a level into a VSI
*/ */
pf->num_rx_queues = vsi->alloc_queue_pairs; pf->num_rx_queues = vsi->num_queue_pairs;
pf->num_tx_queues = vsi->alloc_queue_pairs; pf->num_tx_queues = vsi->num_queue_pairs;
} else { } else {
/* force a reset of TC and queue layout configurations */ /* force a reset of TC and queue layout configurations */
u8 enabled_tc = pf->vsi[pf->lan_vsi]->tc_config.enabled_tc; u8 enabled_tc = pf->vsi[pf->lan_vsi]->tc_config.enabled_tc;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment