Commit b0525b48 authored by Daniel Mack's avatar Daniel Mack Committed by Anton Vorontsov

ds2760_battery: Fix integer overflow for time_to_empty_now

On the device we're currently developing, battery sizes of ~2.8Ah and
current flow of ~600mA are typical.

With that values, the life_sec computation overflows due to the
multiplication by 3600.
Signed-off-by: default avatarDaniel Mack <daniel@caiaq.de>
Cc: Szabolcs Gyurko <szabolcs.gyurko@tlt.hu>
Cc: Matt Reimer <mreimer@vpop.net>
Signed-off-by: default avatarAnton Vorontsov <avorontsov@ru.mvista.com>
parent 83a8af0d
...@@ -211,9 +211,9 @@ static int ds2760_battery_read_status(struct ds2760_device_info *di) ...@@ -211,9 +211,9 @@ static int ds2760_battery_read_status(struct ds2760_device_info *di)
if (di->rem_capacity > 100) if (di->rem_capacity > 100)
di->rem_capacity = 100; di->rem_capacity = 100;
if (di->current_uA) if (di->current_uA >= 100L)
di->life_sec = -((di->accum_current_uAh - di->empty_uAh) * di->life_sec = -((di->accum_current_uAh - di->empty_uAh) * 36L)
3600L) / di->current_uA; / (di->current_uA / 100L);
else else
di->life_sec = 0; di->life_sec = 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment