Commit b381fa32 authored by Felix Fietkau's avatar Felix Fietkau Committed by John W. Linville

ath9k: optimize the hardware hang check

Since it's only called when beacons are stuck, move it to the SWBA handler
tasklet, to avoid doing redundant checks on every single interrupt.
Signed-off-by: default avatarFelix Fietkau <nbd@openwrt.org>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 7b27ba4e
...@@ -369,6 +369,9 @@ void ath_beacon_tasklet(unsigned long data) ...@@ -369,6 +369,9 @@ void ath_beacon_tasklet(unsigned long data)
if (ath9k_hw_numtxpending(ah, sc->beacon.beaconq) != 0) { if (ath9k_hw_numtxpending(ah, sc->beacon.beaconq) != 0) {
sc->beacon.bmisscnt++; sc->beacon.bmisscnt++;
if (!ath9k_hw_check_alive(ah))
ieee80211_queue_work(sc->hw, &sc->hw_check_work);
if (sc->beacon.bmisscnt < BSTUCK_THRESH * sc->nbcnvifs) { if (sc->beacon.bmisscnt < BSTUCK_THRESH * sc->nbcnvifs) {
ath_dbg(common, BSTUCK, ath_dbg(common, BSTUCK,
"missed %u consecutive beacons\n", "missed %u consecutive beacons\n",
......
...@@ -692,17 +692,6 @@ void ath9k_tasklet(unsigned long data) ...@@ -692,17 +692,6 @@ void ath9k_tasklet(unsigned long data)
goto out; goto out;
} }
/*
* Only run the baseband hang check if beacons stop working in AP or
* IBSS mode, because it has a high false positive rate. For station
* mode it should not be necessary, since the upper layers will detect
* this through a beacon miss automatically and the following channel
* change will trigger a hardware reset anyway
*/
if (ath9k_hw_numtxpending(ah, sc->beacon.beaconq) != 0 &&
!ath9k_hw_check_alive(ah))
ieee80211_queue_work(sc->hw, &sc->hw_check_work);
if ((status & ATH9K_INT_TSFOOR) && sc->ps_enabled) { if ((status & ATH9K_INT_TSFOOR) && sc->ps_enabled) {
/* /*
* TSF sync does not look correct; remain awake to sync with * TSF sync does not look correct; remain awake to sync with
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment