Commit b4a24397 authored by Eric Dumazet's avatar Eric Dumazet Committed by David S. Miller

tcp: remove some dead code

Now all skbs in write queue do not contain any payload in skb->head,
we can remove some dead code.
Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent fbf93406
...@@ -1530,7 +1530,7 @@ int tcp_fragment(struct sock *sk, enum tcp_queue tcp_queue, ...@@ -1530,7 +1530,7 @@ int tcp_fragment(struct sock *sk, enum tcp_queue tcp_queue,
{ {
struct tcp_sock *tp = tcp_sk(sk); struct tcp_sock *tp = tcp_sk(sk);
struct sk_buff *buff; struct sk_buff *buff;
int nsize, old_factor; int old_factor;
long limit; long limit;
int nlen; int nlen;
u8 flags; u8 flags;
...@@ -1538,9 +1538,7 @@ int tcp_fragment(struct sock *sk, enum tcp_queue tcp_queue, ...@@ -1538,9 +1538,7 @@ int tcp_fragment(struct sock *sk, enum tcp_queue tcp_queue,
if (WARN_ON(len > skb->len)) if (WARN_ON(len > skb->len))
return -EINVAL; return -EINVAL;
nsize = skb_headlen(skb) - len; DEBUG_NET_WARN_ON_ONCE(skb_headlen(skb));
if (nsize < 0)
nsize = 0;
/* tcp_sendmsg() can overshoot sk_wmem_queued by one full size skb. /* tcp_sendmsg() can overshoot sk_wmem_queued by one full size skb.
* We need some allowance to not penalize applications setting small * We need some allowance to not penalize applications setting small
...@@ -1560,7 +1558,7 @@ int tcp_fragment(struct sock *sk, enum tcp_queue tcp_queue, ...@@ -1560,7 +1558,7 @@ int tcp_fragment(struct sock *sk, enum tcp_queue tcp_queue,
return -ENOMEM; return -ENOMEM;
/* Get a new skb... force flag on. */ /* Get a new skb... force flag on. */
buff = tcp_stream_alloc_skb(sk, nsize, gfp, true); buff = tcp_stream_alloc_skb(sk, 0, gfp, true);
if (!buff) if (!buff)
return -ENOMEM; /* We'll just try again later. */ return -ENOMEM; /* We'll just try again later. */
skb_copy_decrypted(buff, skb); skb_copy_decrypted(buff, skb);
...@@ -1568,7 +1566,7 @@ int tcp_fragment(struct sock *sk, enum tcp_queue tcp_queue, ...@@ -1568,7 +1566,7 @@ int tcp_fragment(struct sock *sk, enum tcp_queue tcp_queue,
sk_wmem_queued_add(sk, buff->truesize); sk_wmem_queued_add(sk, buff->truesize);
sk_mem_charge(sk, buff->truesize); sk_mem_charge(sk, buff->truesize);
nlen = skb->len - len - nsize; nlen = skb->len - len;
buff->truesize += nlen; buff->truesize += nlen;
skb->truesize -= nlen; skb->truesize -= nlen;
...@@ -1626,13 +1624,7 @@ static int __pskb_trim_head(struct sk_buff *skb, int len) ...@@ -1626,13 +1624,7 @@ static int __pskb_trim_head(struct sk_buff *skb, int len)
struct skb_shared_info *shinfo; struct skb_shared_info *shinfo;
int i, k, eat; int i, k, eat;
eat = min_t(int, len, skb_headlen(skb)); DEBUG_NET_WARN_ON_ONCE(skb_headlen(skb));
if (eat) {
__skb_pull(skb, eat);
len -= eat;
if (!len)
return 0;
}
eat = len; eat = len;
k = 0; k = 0;
shinfo = skb_shinfo(skb); shinfo = skb_shinfo(skb);
...@@ -1671,12 +1663,10 @@ int tcp_trim_head(struct sock *sk, struct sk_buff *skb, u32 len) ...@@ -1671,12 +1663,10 @@ int tcp_trim_head(struct sock *sk, struct sk_buff *skb, u32 len)
TCP_SKB_CB(skb)->seq += len; TCP_SKB_CB(skb)->seq += len;
if (delta_truesize) { skb->truesize -= delta_truesize;
skb->truesize -= delta_truesize; sk_wmem_queued_add(sk, -delta_truesize);
sk_wmem_queued_add(sk, -delta_truesize); if (!skb_zcopy_pure(skb))
if (!skb_zcopy_pure(skb)) sk_mem_uncharge(sk, delta_truesize);
sk_mem_uncharge(sk, delta_truesize);
}
/* Any change of skb->len requires recalculation of tso factor. */ /* Any change of skb->len requires recalculation of tso factor. */
if (tcp_skb_pcount(skb) > 1) if (tcp_skb_pcount(skb) > 1)
...@@ -2126,9 +2116,7 @@ static int tso_fragment(struct sock *sk, struct sk_buff *skb, unsigned int len, ...@@ -2126,9 +2116,7 @@ static int tso_fragment(struct sock *sk, struct sk_buff *skb, unsigned int len,
u8 flags; u8 flags;
/* All of a TSO frame must be composed of paged data. */ /* All of a TSO frame must be composed of paged data. */
if (skb->len != skb->data_len) DEBUG_NET_WARN_ON_ONCE(skb->len != skb->data_len);
return tcp_fragment(sk, TCP_FRAG_IN_WRITE_QUEUE,
skb, len, mss_now, gfp);
buff = tcp_stream_alloc_skb(sk, 0, gfp, true); buff = tcp_stream_alloc_skb(sk, 0, gfp, true);
if (unlikely(!buff)) if (unlikely(!buff))
...@@ -2487,12 +2475,8 @@ static int tcp_mtu_probe(struct sock *sk) ...@@ -2487,12 +2475,8 @@ static int tcp_mtu_probe(struct sock *sk)
} else { } else {
TCP_SKB_CB(nskb)->tcp_flags |= TCP_SKB_CB(skb)->tcp_flags & TCP_SKB_CB(nskb)->tcp_flags |= TCP_SKB_CB(skb)->tcp_flags &
~(TCPHDR_FIN|TCPHDR_PSH); ~(TCPHDR_FIN|TCPHDR_PSH);
if (!skb_shinfo(skb)->nr_frags) { __pskb_trim_head(skb, copy);
skb_pull(skb, copy); tcp_set_skb_tso_segs(skb, mss_now);
} else {
__pskb_trim_head(skb, copy);
tcp_set_skb_tso_segs(skb, mss_now);
}
TCP_SKB_CB(skb)->seq += copy; TCP_SKB_CB(skb)->seq += copy;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment