Commit b5e944c5 authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman

staging: rtl8188eu: use safe iterator in tx_beacon_hdl()

This loop calls list_del_init() on the list iterator so it has to use
the _safe() iterator or it leads to an endless loop.

Fixes: 23017c88 ("staging: rtl8188eu: Use list iterators and helpers")
Reviewed-by: default avatarGuenter Roeck <linux@roeck-us.net>
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/YL5iunD5ilf+mKPR@mwandaSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 535ca63b
...@@ -5376,8 +5376,8 @@ u8 tx_beacon_hdl(struct adapter *padapter, unsigned char *pbuf) ...@@ -5376,8 +5376,8 @@ u8 tx_beacon_hdl(struct adapter *padapter, unsigned char *pbuf)
#ifdef CONFIG_88EU_AP_MODE #ifdef CONFIG_88EU_AP_MODE
else { /* tx bc/mc frames after update TIM */ else { /* tx bc/mc frames after update TIM */
struct sta_info *psta_bmc; struct sta_info *psta_bmc;
struct list_head *xmitframe_plist, *xmitframe_phead; struct list_head *xmitframe_phead;
struct xmit_frame *pxmitframe = NULL; struct xmit_frame *pxmitframe, *n;
struct sta_priv *pstapriv = &padapter->stapriv; struct sta_priv *pstapriv = &padapter->stapriv;
/* for BC/MC Frames */ /* for BC/MC Frames */
...@@ -5390,11 +5390,8 @@ u8 tx_beacon_hdl(struct adapter *padapter, unsigned char *pbuf) ...@@ -5390,11 +5390,8 @@ u8 tx_beacon_hdl(struct adapter *padapter, unsigned char *pbuf)
spin_lock_bh(&psta_bmc->sleep_q.lock); spin_lock_bh(&psta_bmc->sleep_q.lock);
xmitframe_phead = get_list_head(&psta_bmc->sleep_q); xmitframe_phead = get_list_head(&psta_bmc->sleep_q);
list_for_each(xmitframe_plist, xmitframe_phead) { list_for_each_entry_safe(pxmitframe, n, xmitframe_phead,
pxmitframe = list_entry(xmitframe_plist, list) {
struct xmit_frame,
list);
list_del_init(&pxmitframe->list); list_del_init(&pxmitframe->list);
psta_bmc->sleepq_len--; psta_bmc->sleepq_len--;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment