Commit ba608091 authored by Lee Jones's avatar Lee Jones Committed by Zack Rusin

drm/vmwgfx/vmwgfx_resource: Fix worthy function headers demote some others

Fixes the following W=1 kernel build warning(s):

 drivers/gpu/drm/vmwgfx/vmwgfx_resource.c:215: warning: Excess function parameter 'obj_type' description in 'vmw_resource_init'
 drivers/gpu/drm/vmwgfx/vmwgfx_resource.c:303: warning: Excess function parameter 'p_res' description in 'vmw_user_resource_noref_lookup_handle'
 drivers/gpu/drm/vmwgfx/vmwgfx_resource.c:328: warning: Function parameter or member 'dev_priv' not described in 'vmw_user_lookup_handle'
 drivers/gpu/drm/vmwgfx/vmwgfx_resource.c:328: warning: Function parameter or member 'tfile' not described in 'vmw_user_lookup_handle'
 drivers/gpu/drm/vmwgfx/vmwgfx_resource.c:328: warning: Function parameter or member 'handle' not described in 'vmw_user_lookup_handle'
 drivers/gpu/drm/vmwgfx/vmwgfx_resource.c:328: warning: Function parameter or member 'out_surf' not described in 'vmw_user_lookup_handle'
 drivers/gpu/drm/vmwgfx/vmwgfx_resource.c:328: warning: Function parameter or member 'out_buf' not described in 'vmw_user_lookup_handle'
 drivers/gpu/drm/vmwgfx/vmwgfx_resource.c:398: warning: Function parameter or member 'dirtying' not described in 'vmw_resource_do_validate'
 drivers/gpu/drm/vmwgfx/vmwgfx_resource.c:601: warning: Function parameter or member 'interruptible' not described in 'vmw_resource_reserve'
 drivers/gpu/drm/vmwgfx/vmwgfx_resource.c:601: warning: Function parameter or member 'no_backup' not described in 'vmw_resource_reserve'
 drivers/gpu/drm/vmwgfx/vmwgfx_resource.c:987: warning: Function parameter or member 'interruptible' not described in 'vmw_resource_pin'

Cc: VMware Graphics <linux-graphics-maintainer@vmware.com>
Cc: Roland Scheidegger <sroland@vmware.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
Signed-off-by: default avatarZack Rusin <zackr@vmware.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210115181313.3431493-11-lee.jones@linaro.org
parent 043948cf
...@@ -202,7 +202,6 @@ int vmw_resource_alloc_id(struct vmw_resource *res) ...@@ -202,7 +202,6 @@ int vmw_resource_alloc_id(struct vmw_resource *res)
* *
* @dev_priv: Pointer to a device private struct. * @dev_priv: Pointer to a device private struct.
* @res: The struct vmw_resource to initialize. * @res: The struct vmw_resource to initialize.
* @obj_type: Resource object type.
* @delay_id: Boolean whether to defer device id allocation until * @delay_id: Boolean whether to defer device id allocation until
* the first validation. * the first validation.
* @res_free: Resource destructor. * @res_free: Resource destructor.
...@@ -288,8 +287,6 @@ int vmw_user_resource_lookup_handle(struct vmw_private *dev_priv, ...@@ -288,8 +287,6 @@ int vmw_user_resource_lookup_handle(struct vmw_private *dev_priv,
* @tfile: Pointer to a struct ttm_object_file identifying the caller * @tfile: Pointer to a struct ttm_object_file identifying the caller
* @handle: The TTM user-space handle * @handle: The TTM user-space handle
* @converter: Pointer to an object describing the resource type * @converter: Pointer to an object describing the resource type
* @p_res: On successful return the location pointed to will contain
* a pointer to a refcounted struct vmw_resource.
* *
* If the handle can't be found or is associated with an incorrect resource * If the handle can't be found or is associated with an incorrect resource
* type, -EINVAL will be returned. * type, -EINVAL will be returned.
...@@ -315,7 +312,7 @@ vmw_user_resource_noref_lookup_handle(struct vmw_private *dev_priv, ...@@ -315,7 +312,7 @@ vmw_user_resource_noref_lookup_handle(struct vmw_private *dev_priv,
return converter->base_obj_to_res(base); return converter->base_obj_to_res(base);
} }
/** /*
* Helper function that looks either a surface or bo. * Helper function that looks either a surface or bo.
* *
* The pointer this pointed at by out_surf and out_buf needs to be null. * The pointer this pointed at by out_surf and out_buf needs to be null.
...@@ -388,6 +385,7 @@ static int vmw_resource_buf_alloc(struct vmw_resource *res, ...@@ -388,6 +385,7 @@ static int vmw_resource_buf_alloc(struct vmw_resource *res,
* @res: The resource to make visible to the device. * @res: The resource to make visible to the device.
* @val_buf: Information about a buffer possibly * @val_buf: Information about a buffer possibly
* containing backup data if a bind operation is needed. * containing backup data if a bind operation is needed.
* @dirtying: Transfer dirty regions.
* *
* On hardware resource shortage, this function returns -EBUSY and * On hardware resource shortage, this function returns -EBUSY and
* should be retried once resources have been freed up. * should be retried once resources have been freed up.
...@@ -586,7 +584,7 @@ vmw_resource_check_buffer(struct ww_acquire_ctx *ticket, ...@@ -586,7 +584,7 @@ vmw_resource_check_buffer(struct ww_acquire_ctx *ticket,
return ret; return ret;
} }
/** /*
* vmw_resource_reserve - Reserve a resource for command submission * vmw_resource_reserve - Reserve a resource for command submission
* *
* @res: The resource to reserve. * @res: The resource to reserve.
...@@ -973,7 +971,7 @@ void vmw_resource_evict_all(struct vmw_private *dev_priv) ...@@ -973,7 +971,7 @@ void vmw_resource_evict_all(struct vmw_private *dev_priv)
mutex_unlock(&dev_priv->cmdbuf_mutex); mutex_unlock(&dev_priv->cmdbuf_mutex);
} }
/** /*
* vmw_resource_pin - Add a pin reference on a resource * vmw_resource_pin - Add a pin reference on a resource
* *
* @res: The resource to add a pin reference on * @res: The resource to add a pin reference on
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment