Commit bbc8c3a4 authored by Philipp Hortmann's avatar Philipp Hortmann Committed by Greg Kroah-Hartman

staging: rtl8192e: Remove ftrace-like logging in r8192E_firmware.c, ...

Remove "Unnecessary ftrace-like logging" as requested by checkpatch.
Reviewed-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarPhilipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/370f47919a69f2f1717f50123c1617cabc78ceca.1663387785.git.philipp.g.hortmann@gmail.comSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 74adc1f0
...@@ -115,10 +115,6 @@ bool rtl92e_config_rf(struct net_device *dev) ...@@ -115,10 +115,6 @@ bool rtl92e_config_rf(struct net_device *dev)
(enum rf90_radio_path)eRFPath, (enum rf90_radio_path)eRFPath,
RegOffSetToBeCheck, RegOffSetToBeCheck,
bMask12Bits); bMask12Bits);
RT_TRACE(COMP_RF,
"RF %d %d register final value: %x\n",
eRFPath, RegOffSetToBeCheck,
RF3_Final_Value);
RetryTimes--; RetryTimes--;
} }
...@@ -142,8 +138,6 @@ bool rtl92e_config_rf(struct net_device *dev) ...@@ -142,8 +138,6 @@ bool rtl92e_config_rf(struct net_device *dev)
goto fail; goto fail;
} }
} }
RT_TRACE(COMP_PHY, "PHY Initialization Success\n");
return true; return true;
fail: fail:
......
...@@ -21,8 +21,6 @@ bool rtl92e_send_cmd_pkt(struct net_device *dev, u32 type, const void *data, ...@@ -21,8 +21,6 @@ bool rtl92e_send_cmd_pkt(struct net_device *dev, u32 type, const void *data,
struct tx_fwinfo_8190pci *pTxFwInfo = NULL; struct tx_fwinfo_8190pci *pTxFwInfo = NULL;
RT_TRACE(COMP_CMDPKT, "%s(),buffer_len is %d\n", __func__, len);
do { do {
if ((len - frag_offset) > CMDPACKET_FRAG_SIZE) { if ((len - frag_offset) > CMDPACKET_FRAG_SIZE) {
frag_length = CMDPACKET_FRAG_SIZE; frag_length = CMDPACKET_FRAG_SIZE;
......
...@@ -77,10 +77,6 @@ static bool _rtl92e_fw_check_ready(struct net_device *dev, ...@@ -77,10 +77,6 @@ static bool _rtl92e_fw_check_ready(struct net_device *dev,
rt_status = _rtl92e_wait_for_fw(dev, CPU_GEN_FIRM_RDY, 20); rt_status = _rtl92e_wait_for_fw(dev, CPU_GEN_FIRM_RDY, 20);
if (rt_status) if (rt_status)
pfirmware->status = FW_STATUS_5_READY; pfirmware->status = FW_STATUS_5_READY;
else
RT_TRACE(COMP_FIRMWARE,
"_rtl92e_is_fw_ready fail(%d)!\n",
rt_status);
break; break;
default: default:
rt_status = false; rt_status = false;
...@@ -149,9 +145,6 @@ bool rtl92e_init_fw(struct net_device *dev) ...@@ -149,9 +145,6 @@ bool rtl92e_init_fw(struct net_device *dev)
} else if (pfirmware->status == FW_STATUS_5_READY) { } else if (pfirmware->status == FW_STATUS_5_READY) {
rst_opt = OPT_FIRMWARE_RESET; rst_opt = OPT_FIRMWARE_RESET;
starting_state = FW_INIT_STEP2_DATA; starting_state = FW_INIT_STEP2_DATA;
} else {
RT_TRACE(COMP_FIRMWARE,
"PlatformInitFirmware: undefined firmware state\n");
} }
for (i = starting_state; i <= FW_INIT_STEP2_DATA; i++) { for (i = starting_state; i <= FW_INIT_STEP2_DATA; i++) {
......
...@@ -46,10 +46,6 @@ void rtl92e_enable_hw_security_config(struct net_device *dev) ...@@ -46,10 +46,6 @@ void rtl92e_enable_hw_security_config(struct net_device *dev)
ieee->hwsec_active = 0; ieee->hwsec_active = 0;
SECR_value &= ~SCR_RxDecEnable; SECR_value &= ~SCR_RxDecEnable;
} }
RT_TRACE(COMP_SEC, "%s:, hwsec:%d, pairwise_key:%d, SECR_value:%x\n",
__func__, ieee->hwsec_active, ieee->pairwise_key_type,
SECR_value);
rtl92e_writeb(dev, SECR, SECR_value); rtl92e_writeb(dev, SECR, SECR_value);
} }
...@@ -60,10 +56,6 @@ void rtl92e_set_swcam(struct net_device *dev, u8 EntryNo, u8 KeyIndex, ...@@ -60,10 +56,6 @@ void rtl92e_set_swcam(struct net_device *dev, u8 EntryNo, u8 KeyIndex,
struct r8192_priv *priv = rtllib_priv(dev); struct r8192_priv *priv = rtllib_priv(dev);
struct rtllib_device *ieee = priv->rtllib; struct rtllib_device *ieee = priv->rtllib;
RT_TRACE(COMP_DBG,
"===========>%s():EntryNo is %d,KeyIndex is %d,KeyType is %d,is_mesh is %d\n",
__func__, EntryNo, KeyIndex, KeyType, is_mesh);
if (EntryNo >= TOTAL_CAM_ENTRY) if (EntryNo >= TOTAL_CAM_ENTRY)
return; return;
...@@ -107,10 +99,6 @@ void rtl92e_set_key(struct net_device *dev, u8 EntryNo, u8 KeyIndex, ...@@ -107,10 +99,6 @@ void rtl92e_set_key(struct net_device *dev, u8 EntryNo, u8 KeyIndex,
return; return;
} }
RT_TRACE(COMP_SEC,
"====>to %s, dev:%p, EntryNo:%d, KeyIndex:%d,KeyType:%d, MacAddr %pM\n",
__func__, dev, EntryNo, KeyIndex, KeyType, MacAddr);
if (DefaultKey) if (DefaultKey)
usConfig |= BIT15 | (KeyType<<2); usConfig |= BIT15 | (KeyType<<2);
else else
...@@ -144,7 +132,6 @@ void rtl92e_set_key(struct net_device *dev, u8 EntryNo, u8 KeyIndex, ...@@ -144,7 +132,6 @@ void rtl92e_set_key(struct net_device *dev, u8 EntryNo, u8 KeyIndex,
} }
} }
} }
RT_TRACE(COMP_SEC, "=========>after set key, usconfig:%x\n", usConfig);
} }
void rtl92e_cam_restore(struct net_device *dev) void rtl92e_cam_restore(struct net_device *dev)
...@@ -163,9 +150,6 @@ void rtl92e_cam_restore(struct net_device *dev) ...@@ -163,9 +150,6 @@ void rtl92e_cam_restore(struct net_device *dev)
0xff, 0xff, 0xff, 0xff, 0xff, 0xff 0xff, 0xff, 0xff, 0xff, 0xff, 0xff
}; };
RT_TRACE(COMP_SEC, "%s:\n", __func__);
if ((priv->rtllib->pairwise_key_type == KEY_TYPE_WEP40) || if ((priv->rtllib->pairwise_key_type == KEY_TYPE_WEP40) ||
(priv->rtllib->pairwise_key_type == KEY_TYPE_WEP104)) { (priv->rtllib->pairwise_key_type == KEY_TYPE_WEP104)) {
......
...@@ -20,8 +20,6 @@ static void _rtl92e_parse_pci_configuration(struct pci_dev *pdev, ...@@ -20,8 +20,6 @@ static void _rtl92e_parse_pci_configuration(struct pci_dev *pdev,
pcie_capability_read_word(priv->pdev, PCI_EXP_LNKCTL, &LinkCtrlReg); pcie_capability_read_word(priv->pdev, PCI_EXP_LNKCTL, &LinkCtrlReg);
RT_TRACE(COMP_INIT, "Link Control Register =%x\n", LinkCtrlReg);
pci_read_config_byte(pdev, 0x98, &tmp); pci_read_config_byte(pdev, 0x98, &tmp);
tmp |= BIT4; tmp |= BIT4;
pci_write_config_byte(pdev, 0x98, tmp); pci_write_config_byte(pdev, 0x98, tmp);
......
...@@ -86,7 +86,6 @@ int rtl92e_resume(struct device *dev_d) ...@@ -86,7 +86,6 @@ int rtl92e_resume(struct device *dev_d)
rtl92e_set_rf_state(dev, eRfOn, RF_CHANGE_BY_INIT); rtl92e_set_rf_state(dev, eRfOn, RF_CHANGE_BY_INIT);
out: out:
RT_TRACE(COMP_POWER, "<================r8192E resume call.\n");
return 0; return 0;
} }
...@@ -149,8 +149,6 @@ static int _rtl92e_wx_force_reset(struct net_device *dev, ...@@ -149,8 +149,6 @@ static int _rtl92e_wx_force_reset(struct net_device *dev,
mutex_lock(&priv->wx_mutex); mutex_lock(&priv->wx_mutex);
RT_TRACE(COMP_DBG, "%s(): force reset ! extra is %d\n",
__func__, *extra);
priv->force_reset = *extra; priv->force_reset = *extra;
mutex_unlock(&priv->wx_mutex); mutex_unlock(&priv->wx_mutex);
return 0; return 0;
...@@ -167,8 +165,6 @@ static int _rtl92e_wx_adapter_power_status(struct net_device *dev, ...@@ -167,8 +165,6 @@ static int _rtl92e_wx_adapter_power_status(struct net_device *dev,
mutex_lock(&priv->wx_mutex); mutex_lock(&priv->wx_mutex);
RT_TRACE(COMP_POWER, "%s(): %s\n", __func__, (*extra == 6) ?
"DC power" : "AC power");
if (*extra || priv->force_lps) { if (*extra || priv->force_lps) {
priv->ps_force = false; priv->ps_force = false;
pPSC->bLeisurePs = true; pPSC->bLeisurePs = true;
...@@ -427,9 +423,6 @@ static int _rtl92e_wx_set_scan(struct net_device *dev, ...@@ -427,9 +423,6 @@ static int _rtl92e_wx_set_scan(struct net_device *dev,
mutex_unlock(&priv->wx_mutex); mutex_unlock(&priv->wx_mutex);
return -1; return -1;
} }
RT_TRACE(COMP_PS,
"=========>%s(): rtl92e_ips_leave\n",
__func__);
mutex_lock(&priv->rtllib->ips_mutex); mutex_lock(&priv->rtllib->ips_mutex);
rtl92e_ips_leave(dev); rtl92e_ips_leave(dev);
mutex_unlock(&priv->rtllib->ips_mutex); mutex_unlock(&priv->rtllib->ips_mutex);
...@@ -681,7 +674,6 @@ static int _rtl92e_wx_set_enc(struct net_device *dev, ...@@ -681,7 +674,6 @@ static int _rtl92e_wx_set_enc(struct net_device *dev,
mutex_unlock(&priv->rtllib->ips_mutex); mutex_unlock(&priv->rtllib->ips_mutex);
mutex_lock(&priv->wx_mutex); mutex_lock(&priv->wx_mutex);
RT_TRACE(COMP_SEC, "Setting SW wep key");
ret = rtllib_wx_set_encode(priv->rtllib, info, wrqu, key); ret = rtllib_wx_set_encode(priv->rtllib, info, wrqu, key);
mutex_unlock(&priv->wx_mutex); mutex_unlock(&priv->wx_mutex);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment