Commit c16db736 authored by Xiang Chen's avatar Xiang Chen Committed by Martin K. Petersen

scsi: hisi_sas: avoid potential v2 hw interrupt issue

When some interrupts happen together, we need to process every interrupt
one-by-one, and should not return immediately when one interrupt process
is finished being processed.
Signed-off-by: default avatarXiang Chen <chenxiang66@hisilicon.com>
Signed-off-by: default avatarJohn Garry <john.garry@huawei.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 917d3bda
...@@ -2606,6 +2606,7 @@ static irqreturn_t int_phy_updown_v2_hw(int irq_no, void *p) ...@@ -2606,6 +2606,7 @@ static irqreturn_t int_phy_updown_v2_hw(int irq_no, void *p)
struct hisi_hba *hisi_hba = p; struct hisi_hba *hisi_hba = p;
u32 irq_msk; u32 irq_msk;
int phy_no = 0; int phy_no = 0;
irqreturn_t res = IRQ_NONE;
irq_msk = (hisi_sas_read32(hisi_hba, HGC_INVLD_DQE_INFO) irq_msk = (hisi_sas_read32(hisi_hba, HGC_INVLD_DQE_INFO)
>> HGC_INVLD_DQE_INFO_FB_CH0_OFF) & 0x1ff; >> HGC_INVLD_DQE_INFO_FB_CH0_OFF) & 0x1ff;
...@@ -2620,15 +2621,15 @@ static irqreturn_t int_phy_updown_v2_hw(int irq_no, void *p) ...@@ -2620,15 +2621,15 @@ static irqreturn_t int_phy_updown_v2_hw(int irq_no, void *p)
case CHL_INT0_SL_PHY_ENABLE_MSK: case CHL_INT0_SL_PHY_ENABLE_MSK:
/* phy up */ /* phy up */
if (phy_up_v2_hw(phy_no, hisi_hba) == if (phy_up_v2_hw(phy_no, hisi_hba) ==
IRQ_NONE) IRQ_HANDLED)
return IRQ_NONE; res = IRQ_HANDLED;
break; break;
case CHL_INT0_NOT_RDY_MSK: case CHL_INT0_NOT_RDY_MSK:
/* phy down */ /* phy down */
if (phy_down_v2_hw(phy_no, hisi_hba) == if (phy_down_v2_hw(phy_no, hisi_hba) ==
IRQ_NONE) IRQ_HANDLED)
return IRQ_NONE; res = IRQ_HANDLED;
break; break;
case (CHL_INT0_NOT_RDY_MSK | case (CHL_INT0_NOT_RDY_MSK |
...@@ -2638,13 +2639,13 @@ static irqreturn_t int_phy_updown_v2_hw(int irq_no, void *p) ...@@ -2638,13 +2639,13 @@ static irqreturn_t int_phy_updown_v2_hw(int irq_no, void *p)
if (reg_value & BIT(phy_no)) { if (reg_value & BIT(phy_no)) {
/* phy up */ /* phy up */
if (phy_up_v2_hw(phy_no, hisi_hba) == if (phy_up_v2_hw(phy_no, hisi_hba) ==
IRQ_NONE) IRQ_HANDLED)
return IRQ_NONE; res = IRQ_HANDLED;
} else { } else {
/* phy down */ /* phy down */
if (phy_down_v2_hw(phy_no, hisi_hba) == if (phy_down_v2_hw(phy_no, hisi_hba) ==
IRQ_NONE) IRQ_HANDLED)
return IRQ_NONE; res = IRQ_HANDLED;
} }
break; break;
...@@ -2657,7 +2658,7 @@ static irqreturn_t int_phy_updown_v2_hw(int irq_no, void *p) ...@@ -2657,7 +2658,7 @@ static irqreturn_t int_phy_updown_v2_hw(int irq_no, void *p)
phy_no++; phy_no++;
} }
return IRQ_HANDLED; return res;
} }
static void phy_bcast_v2_hw(int phy_no, struct hisi_hba *hisi_hba) static void phy_bcast_v2_hw(int phy_no, struct hisi_hba *hisi_hba)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment