Commit c2cc187e authored by Dan Carpenter's avatar Dan Carpenter Committed by David S. Miller

sctp: Fix a big endian bug in sctp_diag_dump()

The sctp_for_each_transport() function takes an pointer to int.  The
cb->args[] array holds longs so it's only using the high 32 bits.  It
works on little endian system but will break on big endian 64 bit
machines.

Fixes: d25adbeb ("sctp: fix an use-after-free issue in sctp_sock_dump")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarNeil Horman <nhorman@tuxdriver.com>
Reviewed-by: default avatarXin Long <lucien.xin@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 20c62c79
...@@ -463,6 +463,7 @@ static void sctp_diag_dump(struct sk_buff *skb, struct netlink_callback *cb, ...@@ -463,6 +463,7 @@ static void sctp_diag_dump(struct sk_buff *skb, struct netlink_callback *cb,
.r = r, .r = r,
.net_admin = netlink_net_capable(cb->skb, CAP_NET_ADMIN), .net_admin = netlink_net_capable(cb->skb, CAP_NET_ADMIN),
}; };
int pos = cb->args[2];
/* eps hashtable dumps /* eps hashtable dumps
* args: * args:
...@@ -493,7 +494,8 @@ static void sctp_diag_dump(struct sk_buff *skb, struct netlink_callback *cb, ...@@ -493,7 +494,8 @@ static void sctp_diag_dump(struct sk_buff *skb, struct netlink_callback *cb,
goto done; goto done;
sctp_for_each_transport(sctp_sock_filter, sctp_sock_dump, sctp_for_each_transport(sctp_sock_filter, sctp_sock_dump,
net, (int *)&cb->args[2], &commp); net, &pos, &commp);
cb->args[2] = pos;
done: done:
cb->args[1] = cb->args[4]; cb->args[1] = cb->args[4];
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment